825642 - Do not ask the admin to confirm the deletion of a custom field if it cannot be deleted

Status: NEW

(Bugzilla :: Administration, task)

Description

[Frédéric Buclin]

When a custom field is marked as obsolete, you can click the "delete" link to delete this custom field. The confirmation page asks you if you are sure, and if you are, you get an error that this custom field cannot be deleted because there are entries in the bugs_activity table for this field. So it doesn't make sense to ask the admin if he is sure; the error message should be thrown immediately.

Comment 1

[Koosha KM]

Attachment: patch v1

Comment 2

[Frédéric Buclin]

Comment on attachment 696801 [details] [diff] [review]
patch v1

>+    ThrowUserError('customfield_has_contents', {'name' => $name }) if $field->has_bugs;

This check is not enough. If there has been any activity about this custom field, then the deletion is impossible.