Avoid mShouldBuildLayer for textboxes on B2G

RESOLVED FIXED in Firefox 19

Status

()

Core
Layout
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Tracking

unspecified
mozilla20
x86
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(blocking-basecamp:+, firefox19 fixed, firefox20 fixed, b2g18 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

"ShouldBuildLayer case should check mVScrollbarBox and mHScrollbarBox for null as well as styles.mHorizontal/mVertical for HIDDEN"
OS: Mac OS X → Gonk (Firefox OS)
Created attachment 696809 [details] [diff] [review]
Avoid layerizing scrollframes that don't have scrollbar boxes
Attachment #696809 - Flags: review?(roc)
Comment on attachment 696809 [details] [diff] [review]
Avoid layerizing scrollframes that don't have scrollbar boxes

Review of attachment 696809 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/generic/nsGfxScrollFrame.cpp
@@ +2088,5 @@
>      ScrollbarStyles styles = GetScrollbarStylesFromFrame();
>      mShouldBuildLayer =
>         (styles.mHorizontal != NS_STYLE_OVERFLOW_HIDDEN ||
>          styles.mVertical != NS_STYLE_OVERFLOW_HIDDEN) &&
> +       (mVScrollbarBox || mHScrollbarBox) &&

Actually I think we should check styles.mHorizontal != HIDDEN && mHScrollbarBox etc. We need to have at least one scrollbar that's both present and has style != HIDDEN.
Created attachment 696824 [details] [diff] [review]
Avoid layerizing scrollframes that don't have scrollbar boxes v2

I'm happy with the stricter condition.
Attachment #696809 - Attachment is obsolete: true
Attachment #696809 - Flags: review?(roc)
Attachment #696824 - Flags: review?(roc)
https://hg.mozilla.org/integration/mozilla-inbound/rev/1004c01bb817

This fixes an unnecessary performance problem with input boxes and only impacts B2G
blocking-basecamp: --- → ?

Updated

6 years ago
blocking-basecamp: ? → +
Assignee: nobody → jmuizelaar
https://hg.mozilla.org/mozilla-central/rev/1004c01bb817
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Does this need to be uplifted?
(In reply to Andrew Overholt [:overholt] from comment #6)
> Does this need to be uplifted?

Yes.

Comment 8

6 years ago
Ryan - would you mind helping here?
Flags: needinfo?(ryanvm)
Keywords: checkin-needed
https://hg.mozilla.org/releases/mozilla-aurora/rev/b07bf54151d1
https://hg.mozilla.org/releases/mozilla-b2g18/rev/e6edce84651f
status-b2g18: --- → fixed
status-firefox19: --- → fixed
status-firefox20: --- → fixed
Flags: needinfo?(ryanvm)
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.