825798 - Device does not power down voluntarily when battery is too low

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P1)

Description

[Michael Vines [:m1] [:evilmachines]]

It has been observed that the device is subjected to an uncontrolled shutdown when the battery is too low to sustain normal operations.  When battery level is too low, Gaia should initiate a system shutdown to prevent data loss and a poor UX that may result from the system /crashing/ due to insufficient power. 

Note that for certain devices a system shutdown once this threshold is met should still occur even when external power is present, as certain operating states can have power requirements that exceed what external power can provide and the device will brown out.

Perhaps system/js/battery_manager.js is one place where this logic could live?

Comment 1

[Joe Cheng [:jcheng] (please needinfo)]

Triage: BB+ for potential blocker for partner

Comment 2

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Oops.  I should have the page refreshed before taking.  Assigning back to Alive.

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

AFAIK, some android devices would shut down at 2% and some are 1%.
Let's do 2% first and don't consider the charging status according to description.

Comment 4

[Joe Cheng [:jcheng] (please needinfo)]

(In reply to Alive Kuo [:alive] from comment #3)
> AFAIK, some android devices would shut down at 2% and some are 1%.
> Let's do 2% first and don't consider the charging status according to
> description.

don't consider the charging status? i am trying to understand what this mean.
Does it mean that if your battery is 0% ~ 1% and you are charging your device while booting up the device (and if the battery is not yet 2% after boot into the OS), it shuts down again?

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Joe Cheng [:jcheng] from comment #4)
> don't consider the charging status? i am trying to understand what this mean.
> Does it mean that if your battery is 0% ~ 1% and you are charging your
> device while booting up the device (and if the battery is not yet 2% after
> boot into the OS), it shuts down again?

My S3 does so. According to :m1 this is reasonable because we don't know if the charging currency is enough for the device to consume. The user should keep charging for a while to restart the phone.

Comment 6

[Joe Cheng [:jcheng] (please needinfo)]

(In reply to Alive Kuo [:alive] from comment #5)
> 
> My S3 does so. According to :m1 this is reasonable because we don't know if
> the charging currency is enough for the device to consume. The user should
> keep charging for a while to restart the phone.

Ok got it! sound good

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/7277

Patch v1:
1. Shutdown after booting if battery.level <= 0.02
2. Shutdown after level changing if battery.level <= 0.02

How do I test:
Modify the value to 0.82 and play a video to see what happened.

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 697348 [details]
https://github.com/mozilla-b2g/gaia/pull/7277

r=me.

I am not sure if the power off code should be put into it's own file or be moved to somewhere else, but let's not dealing that here.

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/dd42ede47ae23d0963ef63c9afaf1d5970163dea