825807 - Some nsNetworkManagerListener tweaks

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Nicholas Nethercote [inactive]]

Some nsNetworkManagerListener tweaks are forthcoming.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Remove unused nsNetworkManagerListener::mManageIOService field.

clang 3.2 warns:

  toolkit/system/dbus/nsNetworkManagerListener.h:43:27 [-Wunused-private-field] private field 'mManageIOService' is not used

This patch removes that field.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Improve the style of nsNetworkManagerListener.{h,cpp}.

This patch makes nsNetworkManagerListener.{h,cpp} follow the conventions at
https://developer.mozilla.org/en-US/docs/Developer_Guide/Coding_Style more
closely:

- Use correct Emacs/Vim modelines.
- Brace the bodies of |if| statements.
- Put function-opening braces on their own line.
- No trailing whitespace.
- Other minor things.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 696926 [details] [diff] [review]
(part 2) - Improve the style of nsNetworkManagerListener.{h,cpp}.

r=me

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 696925 [details] [diff] [review]
(part 1) - Remove unused nsNetworkManagerListener::mManageIOService field.

r=me

Comment 5

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/928eb7835982
https://hg.mozilla.org/integration/mozilla-inbound/rev/4dbd963117b9

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/928eb7835982
https://hg.mozilla.org/mozilla-central/rev/4dbd963117b9