825808 - [B2G][Homescreen] Swiping animation only shows last frame

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Kan-Ru Chen [:kanru] (UTC+9)]

Possible regression from bug 780692

As found in bug 822721 comment #30, turning off throttling will make the animation smooth again.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

This doesn't happen on b2g18 (not sure about aurora), so it's some difference between those two codebases.

Comment 2

[Shelly Lin [:shelly]]

Changeset 116956:955a8b88d796 might be the cause(not yet in b2g18).

changeset:   116956:955a8b88d796
user:        Anthony Jones <[e-mail]>
date:        Sun Dec 23 10:50:04 2012 -0500
summary:     Bug 811950 - Fix async scrolling of position:fixed. r=cjones

Comment 4

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Fix animations by marking transforms as not fixed

Comment 5

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Fix animations by marking transforms as not fixed v2

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 700847 [details] [diff] [review]
Fix animations by marking transforms as not fixed v2

Review of attachment 700847 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/ipc/CompositorParent.cpp
@@ +817,5 @@
>          matrix.ScalePost(c->GetInheritedXScale(),
>                           c->GetInheritedYScale(),
>                           1);
>        }
> +      NS_ASSERTION(!aLayer->GetIsFixedPosition(), "Can't animate fixed layers");

"Can't animate transforms on fixed-position layers"

::: layout/base/FrameLayerBuilder.cpp
@@ +2170,5 @@
>          ownLayer->SetPostScale(mParameters.mXScale,
>                                 mParameters.mYScale);
>        }
>  
> +      ownLayer->SetIsFixedPosition(isFixed && type != TYPE_TRANSFORM);

Add a comment indicating why we're doing this (layers can't support transforms and fixed-pos at the same time).

Comment 7

[Mozilla RelEng Bot]

Try run for 26e2053b29f7 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=26e2053b29f7
Results (out of 101 total builds):
    exception: 1
    success: 84
    warnings: 4
    failure: 12
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-26e2053b29f7

Comment 8

[Mozilla RelEng Bot]

Try run for 163a0f4c28bd is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=163a0f4c28bd
Results (out of 304 total builds):
    exception: 1
    success: 270
    warnings: 25
    failure: 8
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-163a0f4c28bd

Comment 9

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Fix animations by marking transforms as not fixed v3

Carrying over r+

Comment 10

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

See also https://tbpl.mozilla.org/?tree=Try&rev=f857e1dc8808

Comment 11

[Mozilla RelEng Bot]

Try run for f857e1dc8808 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=f857e1dc8808
Results (out of 20 total builds):
    success: 20
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-f857e1dc8808

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c9ab471450fa

Comment 13

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Was it intentional that this doesn't have any flags for b2g18?

Comment 14

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Comment on attachment 701399 [details] [diff] [review]
Fix animations by marking transforms as not fixed v3

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 811950
User impact if declined: Animations get broken if we allow marking of shadow layers as fixed; blocks 811950
Testing completed: Tested home screen and nzherald.co.nz
Risk to taking this patch (and alternatives if risky): Low risk. Transforms are not usually fixed.
String or UUID changes made by this patch: None

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c9ab471450fa

Comment 16

[Alex Keybl [:akeybl]]

blocked a tef+ bug. See https://bugzilla.mozilla.org/show_bug.cgi?id=811950#c27 for an explanation.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/88e48fb94cde

Comment 18

[Lukas Blakk [:lsblakk] use ?needinfo]

Landed on mozilla-b2g18/gaia master prior to the 1/25 branching to mozilla-b2g18_v1_0_0/v1.0.0, updating status-b2g-v1.0.0 to fixed.