825862 - Importing SIM contacts from FTU doesn't block

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect, P3)

Description

[Julien Wajsberg [:julienw]]

STR:
* have a SIM with a lot of contacts
* launch FTU
* at the "import contacts" page, import SIM contact
* then go on without waiting
* launch the contact app
=> no contact is displayed

Expected:
* the user should not be able to finish the FTU if the contacts are still being imported. Or it should work in the background and the Contact app could display a message stating that it is still importing stuff.

For v1, I'd suggest blocking at the "import" screen during import, much like the import in the Contact app works.

Comment 1

[David Scravaglieri [:scravag]]

Blocking + late-l10n if message must be localized

Comment 2

[Kevin Grandon :kgrandon]

I don't mind taking this one, unless someone really wants it :)

Comment 3

[Julien Wajsberg [:julienw]]

I think Vivien began working on this today but I'm sure he won't mind if you take this ;)

Comment 4

[Chris Lee [:clee]]

This does seem like a blocker given:

*User has contacts on their SIM
*Initiates the import, but because they don't wait, the contacts aren't imported
*User can't start using the phone given they don't have any contacts

If we can have this happen in the background with minimal to no impact to the user, that'd be ideal.  Or if we have to wait with 'loading...' that's acceptable as well.

Comment 5

[Kevin Grandon :kgrandon]

+ CC Vivien, in case he is working on it

I actually already have a fix ready for this one - so wondering why you unassigned it? Re-assigning it to myself. Please let me know if I'm not following the correct process.

Comment 6

[Kevin Grandon :kgrandon]

Attachment: Github pull request pointer

Intiial pull request. This reuses styles and strings from the contacts part of the communications app.

Comment 7

[Kevin Grandon :kgrandon]

l10n not needed as we already have a string for this.

Comment 8

[Kevin Grandon :kgrandon]

Comment on attachment 697230 [details]
Github pull request pointer

Looking for a review on this.

Comment 9

[Kevin Grandon :kgrandon]

Note: this pull request also fixes a case where a user could not import contacts in FTU when the sim card does not have a pin.

Comment 10

[Julien Wajsberg [:julienw]]

Comment on attachment 697230 [details]
Github pull request pointer

I'd be more comfortable if you disable the next button during import too.

Otherwise it seems good (didn't try it on a device yet though) !

Comment 11

[Kevin Grandon :kgrandon]

Julien - is that really necessary? We use the same logic here as in several other critical blocking places. (This is also the same as all of the dialogs in Contacts for example)

Comment 12

[Julien Wajsberg [:julienw]]

I'd say yes. Maybe the logic is not correct elsewhere...

The more obvious reason to me is accessibility: the overlay could not be "seen" by some users.

I agree this is not our primary concern today but let's do this correctly on the first time, don't you think ?

Comment 13

[Kevin Grandon :kgrandon]

Comment on attachment 697230 [details]
Github pull request pointer

Julien - Updated the pull request to now disable the nav bar with aria-disabled (Similar approach as to what we do elsewhere in the app).

Are you able to review this one?

Comment 14

[Julien Wajsberg [:julienw]]

Comment on attachment 697230 [details]
Github pull request pointer

r=julienw

tested both with sim security or without sim security, this works very well !

I'm not sure you need to wait for the other reviews for this patch (as it is still quite simple).

thanks !

Comment 15

[Kevin Grandon :kgrandon]

Landed pull request: https://github.com/mozilla-b2g/gaia/pull/7272. Thanks for the help on this one!