Closed Bug 825887 Opened 13 years ago Closed 13 years ago

Removing a download from the panel or from Places removes all instances of that download.

Categories

(Firefox :: Downloads Panel, defect)

Product:
Firefox
Component:
Downloads Panel
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: mconley, Unassigned)

References

Details

STR: 1) Start downloading a file, and then cancel the download while it is in progress. 2) Start re-downloading the same file, and then cancel that download as well. 3) Right click on either of the downloads in the panel (or in Places), and choose to Remove from History. What happens? Both downloads are removed. What's expected? Only the download that was selected should be removed. These lines appear to remove downloads based on their URI, so I suspect this is where the problem is: https://mxr.mozilla.org/mozilla-central/source/browser/components/downloads/content/downloads.js#1246 https://mxr.mozilla.org/mozilla-central/source/browser/components/downloads/content/allDownloadsViewOverlay.js#509
I think it's fine, removing from history is a privacy operation, thus removing all entries is likely what we want. All of the history views work like that (so if you have multiple visits to a page removing one removes all the visits to that page)
Alright, cool - working as designed. Resolving as WONTFIX.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → WONTFIX
I disagree. As a user I saw my original file and a failed duplicate. I wanted to clean up and remove the duplicate but keep the original. Deleting both was *not* my intention or expectation. This left me frustrated and without easy access to my file (I intended to open its location). This may be the way that history/bookmarks work, but for downloads it is not a user's expectation. Deleting a failed or cancelled download is a common enough scenario. I expect just about anyone would view this behavior as a bug because it is not expected or desired.
unfortunately privacy-concerns have an higher priority in the functionality compared to micro-management of the entries. Better failing in management than in privacy :( we may maybe fix the spelling, from Remove From History, to Forget this download, or something like that.
You need to log in before you can comment on or make changes to this bug.