825959 - Build Thunderbird 17.0.4 esr with mock

Status: RESOLVED WONTFIX

(Release Engineering :: Release Requests, defect)

Description

[[e-mail] (:bhearsum)]

Attachment: enable mock for tb 17.0.1 esr

Comment 1

[[e-mail] (:bhearsum)]

in production, forcing some builds to verify it

Comment 2

[[e-mail] (:bhearsum)]

The builds that I triggered went fine.

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 697056 [details] [diff] [review]
enable mock for tb 17.0.1 esr

Backed out due to bug 826567.

Comment 4

[[e-mail] (:bhearsum)]

need to try for this for the next esr

Comment 5

[[e-mail] (:bhearsum)]

Warning: the comments in config.py are in the wrong place. You need to delete from here on: https://github.com/mozilla/build-buildbot-configs/blob/e6215b879206a46f9a6a9013be2efbbc0307f636/mozilla/thunderbird_config.py#L934

Comment 6

[[e-mail] (:bhearsum)]

I struggled to get this working for my staging run. Hopefully this will be of help to you. You need the following AFAICT:
* use_mock from https://hg.mozilla.org/users/bhearsum_mozilla.com/buildbot-configs/rev/4234a4a652c7
* https://hg.mozilla.org/users/bhearsum_mozilla.com/buildbot-configs/rev/9ab469d7aea0
* https://hg.mozilla.org/users/bhearsum_mozilla.com/buildbot-configs/rev/d71cb3f344b8
* https://hg.mozilla.org/users/bhearsum_mozilla.com/buildbot-configs/rev/f22f3cc894c0

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Moving this to 17.0.4 ESR because it's too close to 17.0.3 for comfort.

Comment 8

[[e-mail] (:bhearsum)]

I'm going to make sure this uplift happens right after we ship 17.0.3esr.

Comment 9

[John Hopkins (:jhopkins)]

Attachment: [buildbot-configs] updated patch that uses 'mock' hgSshKey

Comment 10

[[e-mail] (:bhearsum)]

Comment on attachment 713021 [details] [diff] [review]
[buildbot-configs] updated patch that uses 'mock' hgSshKey

Review of attachment 713021 [details] [diff] [review]:
-----------------------------------------------------------------

I think you still need the l10n mozconfig changes like in https://hg.mozilla.org/users/bhearsum_mozilla.com/buildbot-configs/rev/f22f3cc894c0

Comment 11

[[e-mail] (:bhearsum)]

Attachment: fix gcc in l10n mozconfigs too

Comment 12

[[e-mail] (:bhearsum)]

Comment on attachment 716535 [details] [diff] [review]
fix gcc in l10n mozconfigs too

wrong version of gcc - need to fix this.

Comment 13

[[e-mail] (:bhearsum)]

Attachment: use 0moz4 gcc

Comment 14

[[e-mail] (:bhearsum)]

Attachment: bump in repo file

Comment 15

[[e-mail] (:bhearsum)]

Verified:
[root@dev-stage01 tb]# tar -jvxf /pub/mozilla.org/thunderbird/tinderbox-builds/comm-esr17-linux/1361468088/thunderbird-17.0.3.en-US.linux-i686.tar.bz2
[root@dev-stage01 thunderbird]# readelf -D -s *.so | grep UNIQUE
[root@dev-stage01 thunderbird]#

Comment 16

[John Hopkins (:jhopkins)]

Comment on attachment 716547 [details] [diff] [review]
use 0moz4 gcc


The name of the SSH key file changed in the staging configs:

-releaseConfig['hgSshKey']            = '~cltbld/.ssh/ffxbld_dsa'
+releaseConfig['hgSshKey']            = '/home/mock_mozilla/.ssh/tbirdbld_dsa'

r+ once you have the key name fixed up.

Comment 17

[[e-mail] (:bhearsum)]

Attachment: fix ssh keys for staging configs

Comment 18

[Mark Banner (:standard8)]

Comment on attachment 716556 [details] [diff] [review]
bump in repo file

a=Standard8 for landing this on comm-esr17

Comment 19

[[e-mail] (:bhearsum)]

Comment on attachment 716556 [details] [diff] [review]
bump in repo file

15:02 <@bhearsum> Standard8: is there a comm esr17 approval flag i need before landing 
                  https://bugzilla.mozilla.org/attachment.cgi?id=716556&action=edit 
15:07 -!- catlee is now known as catlee-away
15:07 < Standard8> bhearsum: releng component doesn't have one, but a=me.

Comment 20

[[e-mail] (:bhearsum)]

Comment on attachment 716700 [details] [diff] [review]
fix ssh keys for staging configs

Going to reconfig for this sometime this morning. I'll push the comm-esr17 patch at that time, which will trigger builds to verify everything.

Comment 21

[[e-mail] (:bhearsum)]

Attachment: fix compiler for debug builds

Also fixes non-esr.

Comment 22

[[e-mail] (:bhearsum)]

Comment on attachment 717164 [details] [diff] [review]
fix compiler for debug builds

Catlee r+'ed this on IRC.

Comment 23

[Rail Aliiev [:rail]]

In production

Comment 24

[[e-mail] (:bhearsum)]

The comm-esr17 patch caused us to fail a test:
TEST-UNEXPECTED-FAIL | check-sync-dirs.py | build file copies are not in sync
TEST-INFO | check-sync-dirs.py | file(s) found in:               /builds/slave/tb-c-esr17-lx/build/build
TEST-INFO | check-sync-dirs.py | differ from their originals in: /builds/slave/tb-c-esr17-lx/build/mozilla/build
TEST-INFO | check-sync-dirs.py | differing file:                 ./unix/mozconfig.linux
In general, the files in '/builds/slave/tb-c-esr17-lx/build/build' should
always be exact copies of originals in
'/builds/slave/tb-c-esr17-lx/build/mozilla/build'.  A change made to one
should also be made to the other.  See 'check-sync-dirs.py' for more
details.

That will be fixed when bug 813613 lands, which is currently waiting on approval. In the meantime I've starred the builds.

Comment 25

[[e-mail] (:bhearsum)]

Other than known intermittent test failures, things have greened up.

Comment 26

[[e-mail] (:bhearsum)]

Comment on attachment 716556 [details] [diff] [review]
bump in repo file

This was backed out due to bustage in the chemspill 17.0.4esr release. Will be relanded once all the chemspills are done. Also need to land the mozilla-esr17 patch on the relbranches.

Comment 27

[[e-mail] (:bhearsum)]

This was backed out for chemspills. Planning to reland after they ship today.

Comment 28

[[e-mail] (:bhearsum)]

Comment on attachment 716700 [details] [diff] [review]
fix ssh keys for staging configs

Relanded now that chemspills are over. I'll be triggering some builds to verify once a reconfig puts these patches in production again.

Comment 29

[[e-mail] (:bhearsum)]

Builds are looking good.

Comment 30

[[e-mail] (:bhearsum)]

This still broke shit. It's getting backed out again. See https://bugzilla.mozilla.org/show_bug.cgi?id=813613#c38 for details.

Comment 31

[[e-mail] (:bhearsum)]

Given all of the issues we've had with trying to do this, I don't think it's worthwhile investing any more time into. We'll just have to prop up the old build platform until esr17 dies.