Closed
Bug 826014
Opened 12 years ago
Closed 12 years ago
Use strict equality operator in BrowserApp.observe()
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 20
People
(Reporter: tetsuharu, Assigned: tetsuharu)
References
Details
Attachments
(1 file)
|
1.29 KB,
patch
|
cpeterson
:
review+
|
Details | Diff | Splinter Review |
http://hg.mozilla.org/mozilla-central/file/a812ef63de87/mobile/android/chrome/content/browser.js#l1084 We can change this part from `==` to `===`. These flags are expected as boolean values by http://hg.mozilla.org/mozilla-central/file/a812ef63de87/mobile/android/base/Tabs.java#l452
|
Assignee | |
Comment 1•12 years ago
|
||
We need land this bug's patch after Bug 825974 is landed.
Depends on: 825974
|
|
Assignee | |
Comment 2•12 years ago
|
||
|
|
Assignee | |
Updated•12 years ago
|
Attachment #697147 -
Flags: review?(cpeterson)
|
||
Updated•12 years ago
|
Assignee: nobody → saneyuki.s.snyk
Status: NEW → ASSIGNED
Target Milestone: --- → Firefox 20
|
|
||
Comment 3•12 years ago
|
||
Comment on attachment 697147 [details] [diff] [review] patch v1 Review of attachment 697147 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me! I verified that the Java code that sends these JSON variables is inserting booleans, as expected.
Attachment #697147 -
Flags: review?(cpeterson) → review+
|
||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2fe6de3ac044
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•