Update the add-on verifier to check for usages of the global private browsing APIs

RESOLVED FIXED in 2013-03-21

Status

addons.mozilla.org Graveyard
Compatibility Tools
RESOLVED FIXED
5 years ago
2 years ago

People

(Reporter: Ehsan, Assigned: wraithan)

Tracking

unspecified
2013-03-21

Details

(Whiteboard: [fx20])

We need to look for things like the following:

 * nsIPrivateBrowsingService
 * private-browsing
 * private-browsing-transition-complete
 * private-browsing-cancel-vote
 * private-browsing-change-granted

This service has been removed from Firefox 20.

Do I need to provide more information?
Please point to the bug(s) where the service and notifications where removed.
Component: Add-on Validation → Compatibility Tools
Whiteboard: [fx20]
OS: Mac OS X → All
Hardware: x86 → All
Version: ACR-0.9 → unspecified
Bug 818800 removed the service, but that broke Jetpack add-ons, so we had to add it back in bug 826037.  The new nsIPrivateBrowsingService doesn't have any methods or attributes, and the service doesn't do anything.
Is there anything else that we can help with here?  Firefox 20 will go to beta this week...

Thanks!
I'll be looking into add-on compatibility bugs very soon. I'll let you know if there's anything we need.
What will the verifier do if it finds these?  My addon still contains instances of some of these but "understands" they aren't used in Firefox 20 and up.
As explained in comment #1 and comment #2, nsIPrivateBrowsingService and related notifications have been removed. We need to flag all instances of these and show an error.

This is a compatibility error, so the add-on should not be upgraded in this case.

Message:

nsIPrivateBrowsingService and its related observer notifications have been removed due to the new per-window private browsing mode. See <LINK> for more information.

Link: https://developer.mozilla.org/en-US/docs/Updating_addons_broken_by_private_browsing_changes

Affected add-on:

https://addons.mozilla.org/firefox/addon/downthemall/
Assignee: nobody → mattbasta
Target Milestone: --- → 2013-01-31
(In reply to Michael Kraft [:morac] from comment #5)
> What will the verifier do if it finds these?  My addon still contains
> instances of some of these but "understands" they aren't used in Firefox 20
> and up.

You'll see a warning, but it shouldn't be a problem for add-on submission or review.
https://github.com/mozilla/amo-validator/commit/d0a7b2b8c11757b67cf5100994979882949389ba

Warning added.
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Assignee: mattbasta → xwraithanx
Target Milestone: 2013-01-31 → 2013-03-21

Comment 9

5 years ago
(In reply to Jorge Villalobos [:jorgev] from comment #6)
> As explained in comment #1 and comment #2, nsIPrivateBrowsingService and
> related notifications have been removed. We need to flag all instances of
> these and show an error.
> 
> This is a compatibility error, so the add-on should not be upgraded in this
> case.
> 
> Message:
> 
> nsIPrivateBrowsingService and its related observer notifications have been
> removed due to the new per-window private browsing mode. See <LINK> for more
> information.
> 
> Link:
> https://developer.mozilla.org/en-US/docs/
> Updating_addons_broken_by_private_browsing_changes
> 
> Affected add-on:
> 
> https://addons.mozilla.org/firefox/addon/downthemall/

verified at https://addons-dev.allizom.org/en-US/developers/upload/967e81044ab246f9b6dab45f1b8c70e1
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.