826080 - New context-menu module applies the PageContext in cases where it shouldn't

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Dave Townsend [:mossop]]

Let's say you have the following code:

require("context-menu").Item({
  label: "This Page Has Images",
  contentScript: 'self.on("context", function (node) {' +
                 '  return !!document.querySelector("img");' +
                 '});'
});

If you right click in a textarea the old context-menu module would execute the content script listener and show or hide the menu item depending on its result. The new context-menu module first uses the PageContext context which says to not show items in text areas and so the context listener isn't even executed.

Comment 1

[Dave Townsend [:mossop]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/706

Pointer to Github pull-request

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Will this/should this end up on stabilization once landed?

Comment 3

[Dave Townsend [:mossop]]

I think it should

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/faee375caae180369c927f9c2e500ceee297463e
Merge pull request #706 from Mossop/bug826080

Bug 826080 - New context-menu module applies the PageContext in cases where it shouldn't. r=@gozala

Comment 5

[Jeff Griffiths (:canuckistani) (:⚡︎)]

Are we cherry-picking this for 1.13? If it is safe to do so, I vote yes.

Comment 6

[Dave Townsend [:mossop]]

I think we should

Comment 7

[[github robot]]

Commit pushed to stabilization at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/566a45a965b0029e0213fc2f9216bfef0d8e9315
Merge pull request #706 from Mossop/bug826080

Bug 826080 - New context-menu module applies the PageContext in cases where it shouldn't. r=@gozala(cherry picked from commit faee375caae180369c927f9c2e500ceee297463e)