Closed Bug 82612 Opened 23 years ago Closed 23 years ago

Can't build nsHTMLEditRules optimized

Categories

(Core :: DOM: Editor, defect, P3)

PowerPC
Mac System 8.5
defect

Tracking

()

VERIFIED FIXED
mozilla0.9.2

People

(Reporter: sfraser_bugs, Assigned: mozeditor)

References

Details

(Keywords: perf, Whiteboard: [code] fix in hand, a=asa)

Attachments

(2 files)

Building nsHTMLEditRules.cpp with 256Mb RAM/400Mb VM doesn't work. We need to 
refactor WillDeleteSelection() to help the optimizer along.
Keywords: perf
Priority: -- → P3
Whiteboard: [code]
Target Milestone: --- → mozilla0.9.2
With these diffs I can build all of editor, optimized, on a 256meg G3 mac with
VM off.
Status: NEW → ASSIGNED
Whiteboard: [code] → [code] fix in hand
We're doing release builds, right? Is this blocking a developer or the release
team? If not, seems like a candidate to push past 0.9.2.
It prevented me from doing an opt build, which I wanted to do for some debugging 
(and regularly do for performance testing). So it was a blocker for me. I also 
got a call from jj today that he can't do opt. commercial builds on the new 
tinderbox machines (256Mb RAM) because of this bug.
ok, thanks
CheckForEmptyBlock() and CheckForWhitespaceDeletion() don't change the aCancel 
param in any way; should it not be passed to these methods, or should they always 
set it to PR_FALSE?
Whiteboard: [code] fix in hand → [code] fix in hand, need r=, sr=
I had the same question as simon ... though I'm willing to give you an 
r/sr=kin@netscape.com and let you decide if you want to either initialize 
aCancel in your new methods (assuming your going for rules method signature 
consistency), or just remove it completely from the arg list.
Whiteboard: [code] fix in hand, need r=, sr= → [code] fix in hand, need a=
Blocks: 83989
a= asa@mozilla.org for checkin to the trunk.
(on behalf of drivers)
extensive improvements (beyond the patch enclosed in this report) are made by
the patch in 57477.
Whiteboard: [code] fix in hand, need a= → [code] fix in hand, a=asa
I made the suggested changes.  Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
marking verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: