826122 - Pairing fails after cancelling device pair multiple times

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Bluetooth, defect, P1)

Description

[Greg Grisco]

1. Turn bluetooth on
2. Pair with another phone
4. When pairing pop-up comes up, press cancel.
5. Click on the same device, to pair again.

Repeat steps 1-5 multiple times.  Sometimes the "Unable to pair devices" pop-up is shown instead of allowing pairing to take place.

Comment 1

[Joe Cheng [:jcheng] (please needinfo)]

Triage:BB+, P1,C4 - blocking 808607

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Does not seems a Gaia bug. Component switch to reflect that.

Comment 3

[JP Rosevear [:jpr]]

Another like bug 824895 and bug 826108?

Comment 4

[Andrew Overholt [:overholt]]

How are things going here, Eric?

Comment 5

[Eric Chou [:ericchou] [:echou]]

(In reply to JP Rosevear [:jpr] from comment #3)
> Another like bug 824895 and bug 826108?

No, this is not related to bug 824895 and bug 826108. No crash occurs in this case.

Comment 6

[Kai-Chih Hu [:khu]]

Eric, is there any update? 
Thanks.

Comment 7

[Eric Chou [:ericchou] [:echou]]

Handed this over to Thomas.

Comment 8

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Provide meaningful error message if pairing is refused

Bluetooth peer devices can refuse to pair if the initiator tries too often. In this we now print a more meaningful error message.

Comment 9

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Added error messages for Bluetooth pairing refusals

Comment 10

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Provide meaningful error message if pairing is refused

[v2] Split off the code from the strings. Please r+ if you're ok with it. Thanks!

Comment 11

[Fabien Cazenave [:kaze]]

Comment on attachment 699409 [details] [diff] [review]
Added error messages for Bluetooth pairing refusals

Review of attachment 699409 [details] [diff] [review]:
-----------------------------------------------------------------

r=me for the l10n part. Next time please leave the non-English locales unchanged: they’re in the git repository for testing purposes, but the real translation work happens in a separate repository.

Comment 12

[Evelyn Hung]

Comment on attachment 699411 [details] [diff] [review]
Provide meaningful error message if pairing is refused

r=me, the code logic is correct so it's good for me. But we may need UX review this to see if the message is appropriate.
I think it's okay to land first and let UX verify it afterward.

Comment 13

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Added error messages for Bluetooth pairing refusals

Added r+ tag to commit message

Comment 14

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: Provide meaningful error message if pairing is refused

Added r+ tag to commit message

Comment 15

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Removing checkin-needed since this is going into the gaia github and not into our hg repositories.

Comment 16

[Thomas Zimmermann [:tzimmermann] [:tdz]]

A pull request is pending for this bug.

https://github.com/mozilla-b2g/gaia/pull/7417

Comment 17

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/061cef62b7d175ec3c2bbf9d8a9d1b35824d2f5e

Comment 18

[Walter Chen[:ypwalter][:wachen]]

Device: Unagi
Build Identifier: 20130113070202
Update channel: 
   nightly b2g18 (pvt server)  
   unagi.zip	13-Jan-2013 08:06 	100M	 
   https://pvtbuilds.mozilla.org/pub/mozilla.org/b2g/nightly/mozilla-b2g18-unagi-eng/
Git commit info: 2013-11-13 15:15:51

Verified fixed