826133 - Android NDK r8c no longer needs to suppress useless warnings about va_list mangling

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: revert-Wno-psabi.patch

Older Android NDKs logged many, many useless warnings about va_list mangling. These warnings were suppressed in bug 760335. Now that mozilla-central is building with NDK r8c (bug 825453 and bug 825151), we no longer need to suppress these warnings with gcc -Wno-psabi.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Fiddling with the dependency list since this doesn't actually block bug 816993 but rather is enabled by it.

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 697293 [details] [diff] [review]
revert-Wno-psabi.patch

Review of attachment 697293 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/autoconf/android.m4
@@ +143,5 @@
>      OBJCOPY="$android_toolchain"/bin/"$android_tool_prefix"-objcopy
>  
>      CPPFLAGS="-isystem $android_platform/usr/include $CPPFLAGS"
>      CFLAGS="-mandroid -fno-short-enums -fno-exceptions $CFLAGS"
> +    CXXFLAGS="-mandroid -fno-short-enums -fno-exceptions $CXXFLAGS"

Could you also add -Wno-psabi for older versions of gcc?
check how it's done for MOZ_OPTIMIZE_SIZE_TWEAK in configure.in, for instance.

Comment 3

[Chris Peterson [:cpeterson]]

The use of -Wno-psabi with new NDKs is harmless, but unnecessary. The va_list warnings when using old NDKs without -Wno-psabi are also harmless, but very annoying. 

I would prefer either of those cases than adding more conditional code to configure.in. My motivation for this patch was remove a compiler flag that is no longer necessary. :)

Comment 4

[Mike Hommey [:glandium]]

If the choice is between leaving it everywhere and removing it everywhere, I choose the former.

Comment 5

[Chris Peterson [:cpeterson]]

WONTFIX. Sounds reasonable to me. :)