Closed
Bug 826149
Opened 13 years ago
Closed 13 years ago
Add IsFrameTreeTooDeep() check for flex containers
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.30 KB,
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
Just noticed that nsBlockFrame[1] and nsInlineFrame[2] both have IsFrameTreeTooDeep() early-returns. We should add the same in nsFlexContainerFrame, to limit the perf impact that zillions of flex-containers-nested-inside-of-flex-containers can have.
[1] https://mxr.mozilla.org/mozilla-central/source/layout/generic/nsBlockFrame.cpp#989
[2] https://mxr.mozilla.org/mozilla-central/source/layout/generic/nsInlineFrame.cpp#285
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #697343 -
Flags: review?(dbaron)
Comment on attachment 697343 [details] [diff] [review]
fix v1
r=dbaron
Attachment #697343 -
Flags: review?(dbaron) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
inbound is looking pretty backed up right now, so I'm posting the ready-to-land patch (w/ r=dbaron added in commit message) as checkin-needed.
Attachment #697343 -
Attachment is obsolete: true
Attachment #698913 -
Flags: review+
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 4•13 years ago
|
||
Keywords: checkin-needed
|
||
Comment 5•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•