826200 - [Settings] The sub menu string of Call forwarding are overlapped with switch icon

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Leo]

1. Title : The sub menu strings of Call forwarding are overlapped with switch icon
2. Precondition : 
3. Tester's Action : Settings - Call settings - Call fowarding - Forward when unanswered, Forward when unreachable
4. Detailed Symptom (ENG.) : Forward when unanswered and Forward when unreachable string are overlapped with switch icon
5. Detailed Symptom (KOR.) : 
6. Expected : String should not be onverlapped.
7.Reproducibility: Y
1)Frequency Rate : 100%
8.Comparison Results : 
1)Model Comparing : 
9. Attached files: 
1)Log : 
2)Test Contents : 
3)Video file :

Comment 1

[Fernando Jiménez Moreno [:ferjm]]

I don't think this is a critical issue.

Comment 3

[José Antonio Olivera Ortega [:jaoo]]

Rafa, any commnet about what to do here? Thanks!

Comment 4

[Rafael Rebolleda]

I talked with Kaze about this. I think it's enough to just list the phone (i.e. "[phone]") to which calls are forwarded in each case where the feature is active, and a short "disabled" when not in used.

Comment 5

[Maria Angeles Oteo (:oteo)]

Not blocker, but we need to fix it.
Nominated for tracking-b2g18

Comment 6

[José Antonio Olivera Ortega [:jaoo]]

We are waiting what to do here. Could you UX or l12y guys take a look at it please?.

Comment 7

[Rafael Rebolleda]

Is there anything else to take a look at? The substring is solved and copywriters work on the main title for each setting. I guess those new strings will eventually land.

Comment 8

[Guillermo López :willyaranda (probably SLOW response)]

Can I have the PR or the patch to test?

And I don't think there are more issues on CF UI.

Comment 9

[Guillermo López :willyaranda (probably SLOW response)]

Rafa,

We need to change some strings, the problem is that the texts on the main CF screen are being reused inside each function.

On the first one, is a text that can use all the screen, but on the second screen, it has a switch, which takes ~25% of the screen.

So, for example: "Forward when unreacheable" is OK on the main screen, but overlaps the switch button once you press on the function.

What can be the texts for every function?

Maybe changing the title to something more descriptive, from "Call forwarding" to "When unreacheable" can lead us to put on the switch just the "Enable" text.

And work the other options the same way.

Comment 10

[Rafael Rebolleda]

Thank, Guillermo.

The issue with your proposal is that those changes don't imply "forwarding" and the previous screen is both about waiting and forwarding.

I've proposed to José Antonio to split the text for the switch into "Forward" as a title and "When <condition>" as a subtitle, both for the toggle. That should be pretty flexible in terms of localisation while making no compromises by showing all the information.

This should be enough finally land this thing. Any copy enhancements are welcome later ;)

Comment 11

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/7715

Comment 12

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 704656 [details]
Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/7715

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 803533
User impact if declined: None
Testing completed: Yes
Risk to taking this patch (and alternatives if risky): No risk at all. It's about changing some strings.

Comment 13

[Guillermo López :willyaranda (probably SLOW response)]

Comment on attachment 704656 [details]
Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/7715

Thanks! Tested on phone and we will be able to localize properly with this patch :)

Comment 14

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 704656 [details]
Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/7715

l10n changes only. Sounds safe.

Comment 15

[José Antonio Olivera Ortega [:jaoo]]

https://github.com/mozilla-b2g/gaia/commit/09c87d09279d27ef75c16f71cfe803c1de82dc6e

Comment 16

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 704656 [details]
Pointer to Github PR: https://github.com/mozilla-b2g/gaia/pull/7715

Looks like there's just an extra nomination here, and this is already fixed, so clearing.

Comment 17

[Delphine Lebédel [:delphine - Use needinfo]]

Verified fixed in 2013-02-05-07-02-01 pvt nightly b2g18 build