826204 - nsHTMLReflowState ComputedHeight() & mComputedHeight should be compared to NS_AUTOHEIGHT, not NS_UNCONSTRAINEDSIZE

Status: NEW

(Core :: Layout, defect)

Description

[Daniel Holbert [:dholbert]]

Right now, we compare nsHTMLReflowState::ComputedHeight() (and mComputedHeight) to NS_AUTOHEIGHT in some places and to NS_UNCONSTRAINEDSIZE in other places.

Those happen to be #defined to be equal, so it doesn't actually make a functional difference which one you use.  But for consistency/readability, we should stick with one or the other, as the "special value" for computed-height.

Right now, the nsHTMLReflowState.h documentation for mComputedHeight mentions NS_AUTOHEIGHT, *not* NS_UNCONSTRAINEDSIZE -- so that's probably what we should be using.
https://mxr.mozilla.org/mozilla-central/source/layout/generic/nsHTMLReflowState.h?rev=129629b6106f&mark=272-278#265