826208 - [Settings] Time format error

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Leo]

1. Title : Time format error
2. Precondition : 
3. Tester's Action : Settings - Language - Francais - back - Date & Time - Un check Set automatically - Select time
4. Detailed Symptom (ENG.) : Sample Format display 12-hour format on Lanugae menu. But display 24-hour format on Date & Time menu
5. Detailed Symptom (KOR.) : 
6. Expected : Display same format between Language and Date & Time
7.Reproducibility: Y
1)Frequency Rate : 100%
8.Comparison Results : 
1)Model Comparing : 
9. Attached files: 
1)Log : 
2)Test Contents : 
3)Video file :

Comment 1

[Lukas Blakk [:lsblakk] use ?needinfo]

Tracking should be enough for this bug since it's basically a UI/Localization polish.

Comment 2

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Attachment: Pull Request #8833 - Update date and time format once language is changed

Comment 3

[Evelyn Hung]

Comment on attachment 729730 [details]
Pull Request #8833 - Update date and time format once language is changed

r=me. thanks.

Comment 4

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Thanks Evelyn, updated the commit. Feel free to merge it to master.

Comment 5

[Evelyn Hung]

merged to gaia-master
https://github.com/mozilla-b2g/gaia/commit/a01f6966b0c8cdd8988353dad95aae893bf15849

Comment 6

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Comment on attachment 729730 [details]
Pull Request #8833 - Update date and time format once language is changed

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): settings/date_time
User impact if declined: Minimum 
Testing completed: Yes
Risk to taking this patch (and alternatives if risky): None
String or UUID changes made by this patch: No

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit a01f6966b0c8cdd8988353dad95aae893bf15849 as:
v1-train: 500a6930e2509a96e81b1d1ea800d775045e812f