Closed Bug 826274 Opened 11 years ago Closed 11 years ago

With disabled lock screen, unlock screen shows and unlock sounds is played when restarted

Categories

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System::Lockscreen
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-basecamp:-)

Status:
RESOLVED FIXED
Project Flags:
blocking-basecamp -

People

(Reporter: nbp, Assigned: kgrandon)

Details

(Keywords: b2g-testdriver, polish, Whiteboard: [good first bug])

Attachments

(1 file)

Github pull request
46 bytes, text/x-github-pull-request
timdream
: review+
Details | Review 
STR:
 - Disable the lock screen in the settings app.
 - Long press on the power button.
 - Restart.

Seen:
 - restart & unlock sounds & home screen

Expected:
 - restart & home screen

Device info:
 - OS: 1.0.0
 - Hardware: nice
 - Platform: 18.0
 - Build id: 20121226070202
 - Channel: beta
 - Git info: 2012-12-26 15:10:59  (unknown sha1)
blocking-basecamp: ? → -
Keywords: polish
Whiteboard: [good first bug]
Wirh  20130423 1.0.1, I also get the lock screen after a reboot.  After that, it works properly when the phone is asleep.  But, just the first time after the reboot, we seem to ignore the fact that the lock is disabled.
Summary: Unlock sounds is played when restarted (with disabled lock screen) → With disabled lock screen, unlock screen shows and unlock sounds is played when restarted
I know this is a good first bug, but this is driving me absolutely crazy. Must fix.
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Attached file Github pull request — 
Quick fix - this is killing my ears.

I think we should leverage the "instant" variable here to disable the sound. It doesn't make sense to play the sound when the unlock action is "instant". Let me know what you think.
Attachment #8347986 - Flags: review?(timdream)
Updated the PR from true -> false.
Comment on attachment 8347986 [details] [review]
Github pull request

Thanks for the band-aid fix. In the long run the lock screen itself should have a sane initialization route or even isolated into an app (bug 898348) ...
Attachment #8347986 - Flags: review?(timdream) → review+
Landed: https://github.com/mozilla-b2g/gaia/commit/545aacf3feff6430140cc9ade757002df4895b77
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: