82628 - UTF-8 converter is invoked, when unescaping a URL in "Send Page"

Status: RESOLVED WORKSFORME

(MailNews Core :: Composition, defect)

Description

[[e-mail] (away - not reading bugmail)]

go to

http://maps.yahoo.com/py/maps.py?
BFCat=&Pyt=Tmap&newFL=Use+Address+Below&addr=326+Galvez+Street&csz=Palo+Alto%
2C+CA+94304-2203&country=us&Get%A0Map=Get+Map

do a send page.  when we unescape that url in MsgComposeCommands.js, we invoke
the UTF-8 converter.

from  bug 58532 and bug 58980.

About the conversion error, the is a correct behavior because UTF-8 converter
was used for non UTF-8 input.

In nsGlobalWindow::Unescape, UTF-8 was used as a default and a document charset
overrides it when it's available. So in case of 0xA0, if the document charset is
set as "ISO-8859-1" then UTF-8 converter is not used and the conversion should
cause no error. I think compose window charset is set as mail send default
charset (for US build that's "ISO-8859-1"). So I am not sure why UTF-8 converter
was used.

2229   // Get the document character set
2230   charset.AssignWithConversion("UTF-8");        // default to utf-8
2231   if (mDocument) {
2232     nsCOMPtr<nsIDocument> doc(do_QueryInterface(mDocument));
2233
2234     if (doc)
2235       result = doc->GetDocumentCharacterSet(charset);
2236   }

------- Additional Comments From Katsuhiko Momoi 2001-01-05 12:27 -------

We need to have consistent policy on what charset to use for
URL escaping/unescaping. We should agree on a policy about this
taking into account other URL issues in Mozilla.

Comment 1

[[e-mail] (away - not reading bugmail)]

*** Bug 58890 has been marked as a duplicate of this bug. ***

Comment 2

[[e-mail] (away - not reading bugmail)]

reposting the URL in the body:

<A HREF="http://maps.yahoo.com/py/maps.py?
BFCat=&Pyt=Tmap&newFL=Use+Address+Below&addr=326+Galvez+Street&csz=Palo+Alto%
2C+CA+94304-2203&country=us&Get%A0Map=Get+Map">http://maps.yahoo.com/py/maps.py?
BFCat=&Pyt=Tmap&newFL=Use+Address+Below&addr=326+Galvez+Street&csz=Palo+Alto%
2C+CA+94304-2203&country=us&Get%A0Map=Get+Map</A>

I also verified that a current build (05242001) still fails here:

http://lxr.mozilla.org/seamonkey/source/mailnews/compose/resources/content/MsgCo
mposeCommands.js#858

Comment 3

[[e-mail] (away - not reading bugmail)]

(ftang using jbetak's account)
move to future, I don't think this is critical

Comment 4

[Frank Tang]

jbetak's contract is up. Bulk move bugs to ftang

Comment 5

[Frank Tang]

what a hack. I have not touch mozilla code for 2 years. I didn't read these bugs
for 2 years. And they are still there. Just close them as won't fix to clean up.

Comment 6

[Travis Chase]

Mass Reassign Please excuse the spam

Comment 7

[Travis Chase]

Mass Re-opening Bugs Frank Tang Closed on Wensday March 02 for no reason, all
the spam is his fault feel free to tar and feather him

Comment 8

[Travis Chase]

Reassigning Franks old bugs to Jungshik Shin for triage - Sorry for spam

Comment 9

[Mike Cowperthwaite]

(In reply to comment #0)
> http://maps.yahoo.com/py/maps.py?
> BFCat=&Pyt=Tmap&newFL=Use+Address+Below&addr=326+Galvez+Street&csz=Palo+Alto%
> 2C+CA+94304-2203&country=us&Get%A0Map=Get+Map

This URL is no longer valid; Yahoo Maps no longer puts a "%A0" in the URL string.  I'm not sure how to test whether this bug still applies.  Since reporter never provided Actual/Expected results, I'm not even sure what to expect -- I'm guessing that the %A0 was converted to %C2%A0, and that further, Yahoo Maps rejected the converted URL when it was fed back.

But I tried this:
  https://bugzilla.mozilla.org/query.cgi?No%A0Problem
If I understand correctly, Bugzilla doesn't set an encoding for this page.  It defaults to ISO-8859-1 for me, and if I Send Link, the link is set up verbatim in the compose window.  Same happens when I force the page encoding to UTF-8.

This within Seamonkey 1.5a-1123, and the same with Firefox 2.0.0.1-1129 linking to Thunderbird 3a1-1206.

WFM, I guess.  Jungshik, do you have any thoughts about this?

Comment 10

[buovjaga]

Code is now here and obviously has seen a lot of churn after original post: https://hg.mozilla.org/comm-central/file/tip/mail/components/compose/content/MsgComposeCommands.js

Let's set to WFM per last comment.