Closed
Bug 826286
Opened 13 years ago
Closed 13 years ago
Selecting a timezone in the Date & Time screen in FTE always displays an incorrect time - should display the time respective of the timezone
Categories
(Firefox OS Graveyard :: Gaia::First Time Experience, defect, P3)
Firefox OS Graveyard
Gaia::First Time Experience
ARM
Gonk (Firefox OS)
Tracking
(blocking-basecamp:+)
People
(Reporter: jsmith, Assigned: timdream)
Details
Attachments
(1 file)
In the date & time screen in the FTE:
If a user selects a timezone in the date & time screen, the time shown in the last selection box is wrong. We should display the time respective of the user's timezone.
| Reporter | ||
Comment 1•13 years ago
|
||
This one may be worth re-sending into triage - it's annoying in setup, 100% reproducible, and embarrassing.
blocking-basecamp: --- → ?
Updated•13 years ago
|
Assignee: nobody → kaze
Updated•13 years ago
|
blocking-basecamp: ? → +
Priority: -- → P3
Target Milestone: --- → B2G C4 (2jan on)
Once we click into the time, the time corrects itself.
FYI: the build script also has an issue with setting the time. I mentioned this in bug 806467.
| Assignee | ||
Comment 4•13 years ago
|
||
Stealing, since Naoki told me this bug about is a fairly simple UI out-of-sync issue.
| Assignee | ||
Updated•13 years ago
|
Assignee: kaze → timdream+bugs
| Assignee | ||
Comment 5•13 years ago
|
||
Kaze, would you review the patch please?
Attachment #698711 -
Flags: review?(kaze)
| Assignee | ||
Comment 6•13 years ago
|
||
Comment on attachment 698711 [details]
Github: https://github.com/mozilla-b2g/gaia/pull/7331 or https://github.com/mozilla-b2g/gaia/pull/7332
remove the review flag -- I should patch tz_select.js instead.
Attachment #698711 -
Flags: review?(kaze)
| Assignee | ||
Comment 7•13 years ago
|
||
Comment on attachment 698711 [details]
Github: https://github.com/mozilla-b2g/gaia/pull/7331 or https://github.com/mozilla-b2g/gaia/pull/7332
https://github.com/mozilla-b2g/gaia/pull/7331
https://github.com/mozilla-b2g/gaia/pull/7332
I am not sure what's reviewer's preference on this, so I decided to submit both of them. Kaze, could your r+ either of them? Thanks.
Attachment #698711 -
Attachment description: Github: https://github.com/mozilla-b2g/gaia/pull/7331 → Github: https://github.com/mozilla-b2g/gaia/pull/7331 or https://github.com/mozilla-b2g/gaia/pull/7332
Attachment #698711 -
Flags: review?(kaze)
| Assignee | ||
Comment 8•13 years ago
|
||
Comment on attachment 698711 [details]
Github: https://github.com/mozilla-b2g/gaia/pull/7331 or https://github.com/mozilla-b2g/gaia/pull/7332
fernando should be able to review this too :)
Attachment #698711 -
Flags: review?(fernando.campo)
Comment 9•13 years ago
|
||
Comment on attachment 698711 [details]
Github: https://github.com/mozilla-b2g/gaia/pull/7331 or https://github.com/mozilla-b2g/gaia/pull/7332
looks good, thanks!
Attachment #698711 -
Flags: review?(kaze) → review+
| Assignee | ||
Comment 10•13 years ago
|
||
(In reply to Fabien Cazenave [:kaze] from comment #9)
> Comment on attachment 698711 [details]
> Github: https://github.com/mozilla-b2g/gaia/pull/7331 or
> https://github.com/mozilla-b2g/gaia/pull/7332
>
> looks good, thanks!
Are you talking about 7331 or 7332 here?
Flags: needinfo?(kaze)
Comment 11•13 years ago
|
||
Flags: needinfo?(kaze)
Comment 12•13 years ago
|
||
(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) from comment #10)
> Are you talking about 7331 or 7332 here?
I’ve just merged 7332.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Attachment #698711 -
Flags: review?(fernando.campo)
You need to log in
before you can comment on or make changes to this bug.
Description
•