Closed
Bug 826381
Opened 11 years ago
Closed 11 years ago
SUMO Default bookmark url is redirected
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox19 verified, firefox20 verified, firefox21 unaffected)
VERIFIED
FIXED
Firefox 20
Tracking | Status | |
---|---|---|
firefox19 | --- | verified |
firefox20 | --- | verified |
firefox21 | --- | unaffected |
People
(Reporter: wesj, Unassigned)
Details
Attachments
(1 file)
1.43 KB,
patch
|
mfinkle
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
We currently ship a default bookmark to http://support.mozilla.org/@AB_CD@/mobile. With the recent sumo rewrite it now redirects to http://support.mozilla.org/@AB_CD@/products/mobile (Not the products bit). Everything still works, but because our bookmark points to a different url, you end up with an about:home thumbnail that never fills in (until you visit enough sites to push it off screen). We should just avoid the the redirect and ship the correct url for now. In the long run, it would be nice if we could be smarter about finding thumbnails for redirects, but that will likely be tough.
Reporter | ||
Comment 1•11 years ago
|
||
I'm going to ping some sumo people to find out if they're expecting more churn here.
Attachment #697554 -
Flags: review?(mark.finkle)
Comment 2•11 years ago
|
||
Comment on attachment 697554 [details] [diff] [review] Patch Request approval for aurora (fx19) too
Attachment #697554 -
Flags: review?(mark.finkle) → review+
Reporter | ||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/11f420dd6b47
Reporter | ||
Comment 4•11 years ago
|
||
Comment on attachment 697554 [details] [diff] [review] Patch [Approval Request Comment] Bug caused by (feature/regressing bug #): SUMO revamp User impact if declined: New users (or clear private data) may never get a thumbnail on about:home Testing completed (on m-c, etc.): Landed on mc today Risk to taking this patch (and alternatives if risky): Very low risk. I've talked to sumo and they're not expecting any more churn here. String or UUID changes made by this patch: None. This string is "localized" (by adding the current builds locale string) at build time. Does not (and can not) need to be localized by localizers.
Attachment #697554 -
Flags: approval-mozilla-aurora?
Comment 5•11 years ago
|
||
Also https://hg.mozilla.org/integration/mozilla-inbound/rev/e9e8cb0ae492 to fix the test that checks for that URL
Comment 6•11 years ago
|
||
... and https://hg.mozilla.org/integration/mozilla-inbound/rev/5a7b468178a2 also.
Updated•11 years ago
|
Attachment #697554 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Reporter | ||
Comment 7•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/f98ccdeee9d3
Reporter | ||
Comment 8•11 years ago
|
||
Whoops wrong one. This is a fold up of my patch and kats': https://hg.mozilla.org/releases/mozilla-aurora/rev/f98ccdeee9d3
Comment 9•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/11f420dd6b47 https://hg.mozilla.org/mozilla-central/rev/e9e8cb0ae492 https://hg.mozilla.org/mozilla-central/rev/5a7b468178a2
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
Updated•11 years ago
|
status-firefox19:
--- → fixed
status-firefox20:
--- → fixed
Comment 10•11 years ago
|
||
Firefox 19 Beta 1 (2013-01-08) Firefox 20.0a2 (2013-01-09) Device: Galaxy Nexus OS:Android 4.1. This was push in beta channel also as Firefox 19 is currently in Beta. The correct URL is in Both Firefox 19 an 20. I will mark the bug Verified Fixed.
Status: RESOLVED → VERIFIED
status-firefox21:
--- → unaffected
Assignee | ||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•