826388 - Allow single click on line numbers to add/remove breakpoints

Status: RESOLVED FIXED

(DevTools :: Source Editor, defect)

Description

[Mihai Sucan [:msucan]]

Users are complaining about the nonintuitive way we currently handle the debugger and line gutters. Users expect that a single click on the line numbers adds/removes breakpoints.

Comment 1

[Mihai Sucan [:msucan]]

Attachment: proposed fix

Quick fix.

Comment 2

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 697570 [details] [diff] [review]
proposed fix

works as advertised.

Comment 3

[Mihai Sucan [:msucan]]

Thanks!

Comment 4

[Mihai Sucan [:msucan]]

https://hg.mozilla.org/integration/fx-team/rev/3618915c083f

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/mozilla-central/rev/3618915c083f

Comment 6

[Mihai Sucan [:msucan]]

Comment on attachment 697570 [details] [diff] [review]
proposed fix

[Approval Request Comment]
Bug caused by (feature/regressing bug #): not applicable.
User impact if declined: this patch improves the user experience in the JS debugger.
Testing completed (on m-c, etc.): this patch landed in fx-team and m-c.
Risk to taking this patch (and alternatives if risky): close to no risks. alternatives: none.
String or UUID changes made by this patch: no such changes.

Thank you!

Comment 7

[Alex Keybl [:akeybl]]

Comment on attachment 697570 [details] [diff] [review]
proposed fix

Given the risk profile here, approving for Aurora 20.

Comment 8

[Mihai Sucan [:msucan]]

Thank you Alex!

Landed in aurora:
https://hg.mozilla.org/releases/mozilla-aurora/rev/c75343566eea

Comment 9

[Ioana (away)]

Verified as fixed on:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:20.0) Gecko/20100101 Firefox/20.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20100101 Firefox/20.0
Mozilla/5.0 (X11; Linux i686; rv:20.0) Gecko/20100101 Firefox/20.0

Comment 10

[Ioana (away)]

Verified as fixed on Firefox 21 RC - 20130507015204.