826465 - [SMS] Selecting contact created directly with the API without 'type' shows null for carrier

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Misty Byrd]

Attachment: screen shot of contact showing null

Perquisites:
1.Import fake contacts from UI tests app

Issue: When selecting a UI tests imported contact from the contact list carrier shows as null.


Steps to Reproduce:
1) Install Build 20130103070201 v.1 on a Unagi Device
2) Verify UI tests contacts have been added to the device
3) Select SMS app
4) Select + to open a new message
5) Select contact icon to bring up contacts
6) Select UI tests imported contact with a properly formatted phone number

Expected: Contact inserted into address field showing number and carrier

Actual:
Contact inserted into address field showing number and “null” for carrier this seems to just be an issue for Imported contacts from the  UI tests app

Notes:
Repro frequency:
 10/10 times

See Screenshot / Attachment:

Comment 1

[Borja Salguero [:borjasalguero]]

Is this happening with a contact create by your own? Or it's only failing using the test-app? Thanks!

Comment 2

[Misty Byrd]

 Response to comment 1 Yes, this is only for the imported contacts from the test-app, the repro steps from original bug instructed to import contacts from UI test.

Comment 3

[Borja Salguero [:borjasalguero]]

Im afraid that this bug it's related with how 'test-app' it's creating the contacts list, no with the SMS App. Im gonna update the name of the bug in order to check what it's happening to this test app. Thanks for your quick answer!

Comment 4

[Borja Salguero [:borjasalguero]]

Brief summary. I've realized that this bug it's impossible to reproduce with our apps (Contacts APP, FTU...) due to for us every phone number it's tied to a type, and it's impossible to add a phone number without this info. However, the API lets us to create a contact without type (that's what it's happening with UI-Test App), so the SMS App shows 'null'. It seems an edge case, but it doesnt, because we could create 'Contacts' from different apps (Third party apps for example), and this error will be there!

So after talking with Ayman and retrieving UX suggestions, Im gonna create a small patch to SMS App in order to prevent this scenario.

Im gonna rename it again in order to explain better what we are solving!

Comment 5

[Borja Salguero [:borjasalguero]]

Attachment: PR

Comment 6

[Borja Salguero [:borjasalguero]]

Comment on attachment 700298 [details]
PR

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 700298 [details]
PR

a=me

Thanks Borja!

Comment 8

[mdaniloff]

Verified Fixed on Unagi build 20130211070202
Dec Kernel 5th