826497 - Favicons flash while typing in url bar

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect, P2)

Description

[Jeff Muizelaar [:jrmuizel]]

This is sort of distracting.
STR:
with a bunch of people.m.o urls in the history type in a p.m.o url

Comment 1

[Ben Francis [:benfrancis]]

FYI: They flash because the results get updated every time you hit a key

Comment 2

[Ben Francis [:benfrancis]]

We can try to take a look at this, adding to backlog.

Comment 4

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

I proposed a patch reequest for this bug here: https://bugzilla.mozilla.org/show_bug.cgi?id=877579

Should I move the patch attachment here?

Comment 5

[Ben Francis [:benfrancis]]

(In reply to Sergi Mansilla from comment #4)
> I proposed a patch reequest for this bug here:
> https://bugzilla.mozilla.org/show_bug.cgi?id=877579
> 
> Should I move the patch attachment here?

Erm, yes please that would be grand :) Thanks for the patch!

Comment 7

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Attachment: Github Pull Request

Comment 8

[Dale Harvey (:daleharvey)]

Comment on attachment 755885 [details] [diff] [review]
Github Pull Request

Clearing the review for this time round, mostly just to give ben some time to feedback as well

Theres a bunch of all very minor nits on github, but overall r+'ing, this makes a surprisingly big improvement, I hadnt noticed how jarring those flash favicons were until I didnt see them.

With the nits fixed I am good to merge this, but just r? me again when the patch is updated and I will merge.

Cheers

Comment 9

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Comment on attachment 755885 [details] [diff] [review]
Github Pull Request

Addressed reviewer points.

Comment 10

[Dale Harvey (:daleharvey)]

Comment on attachment 755885 [details] [diff] [review]
Github Pull Request

Got a last little nit that I think is a bit cleaner, but good to go, cheers

Comment 11

[Dale Harvey (:daleharvey)]

Merged in: http://git.io/pZpO4g