82652 - Editable menulist modifications needed.

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Charles Manske]

The xul widget <menulist editable="true"> combines a textbox (input field) with
a popup menulist. The default behavior for this has been modified according
to expected standards, but there are bugs with the current behavior. This bug
is to track the necessary changes neede to make it work correctly in Composer's
Advanced edit dialog (bug 71743) and in the Forms Manager (bug to be filed soon.)

Comment 1

[Charles Manske]

Adding blockers.

Comment 2

[Charles Manske]

Attachment: Fixes menulist widget problems and compatability with Form Manager dialogs

Comment 3

[Charles Manske]

Ready for review

Comment 4

[Stephen P. Morse]

When I apply the patch given here, I get the message:

Patching file menulist.xml using Plan A...
Hunk #1 failed at 174.
Hunk #2 failed at 269.
2 out of 2 hunks failed--saving rejects to menulist.xml.rej
done

Comment 5

[Stephen P. Morse]

I believe that the reason the patch is failing is that I am applying it against 
version 1.2 of the file.  The patch is against 1.1.  And the difference between 
1.1 and 1.2 involve the same area that this patch involves.

Charlie, you probably need to update your file and then regenerate the patch.

Comment 6

[Charles Manske]

Attachment: Updated patch

Comment 7

[Charles Manske]

Wait! last one won't work either.

Comment 8

[Charles Manske]

Attachment: Updated patch. I forgot to clear the sticky tag from a "-r" update!

Comment 9

[Charles Manske]

Attachment: Updated patch: No need to auto-append <menupopup>; Use <handler event="create"> trigger calling selectInputFieldValueInList() when menu opens

Comment 10

[Stephen P. Morse]

You forgot to remove the diagnostic dump statements from your patch.

Comment 11

[Charles Manske]

Attachment: Updated patch: Removed dump; Suggested change to not throw error when setting active child to null in popup

Comment 12

[Charles Manske]

Attachment: Updated patch: support for up and down keys to open menulist when in inputfield

Comment 13

[Charles Manske]

r=kin

Comment 14

[Joe Hewitt (gone)]

sr=hewitt

Comment 15

[Charles Manske]

Attachment: Final patch! Hewitt helped figure out how to prevent up/down key from being processed when menupopup opens

Comment 16

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 17

[Charles Manske]

checked in.