826523 - 'TypeError: tabs.open is not a function' with latest nightly

Status: RESOLVED WORKSFORME

(Add-on SDK Graveyard :: General, defect)

Description

[Benoit Girard (:BenWa)]

My extension can't open tabs anymore which completely break my extension. KWierso can't reproduce this on Windows so perhaps it's mac only.

STR:
1) Go to an empty temporary directory
2) run 'git clone [e-mail]:bgirard/Gecko-Profiler-Addon.git . && ./bootstrap.sh'
3) Update test.sh with the location of your nightly build
4) Run test.sh
5) Click on the top right globe icon and click on 'Settings'. Instead of having a settings tab open it throws the following error in the error console:

Timestamp: 2013-01-03 6:44:50 PM
Error: geckoprofiler: An exception occurred.
Traceback (most recent call last):
  File "resource://jid0-edalmuivkozlouyij0lpdx548bc-at-jetpack/addon-sdk/lib/sdk/timers.js", line 31, in notify
    callback.apply(null, args);
  File "resource://jid0-edalmuivkozlouyij0lpdx548bc-at-jetpack/addon-sdk/lib/sdk/content/worker.js", line 109, in onContentEvent/<
    self._emit.apply(self, JSON.parse(args));
  File "resource://jid0-edalmuivkozlouyij0lpdx548bc-at-jetpack/addon-sdk/lib/sdk/deprecated/events.js", line 123, in _emit
    return this._emitOnObject.apply(this, args);
  File "resource://jid0-edalmuivkozlouyij0lpdx548bc-at-jetpack/addon-sdk/lib/sdk/deprecated/events.js", line 153, in _emitOnObject
    listener.apply(targetObj, params);
  File "resource://jid0-edalmuivkozlouyij0lpdx548bc-at-jetpack/addon-sdk/lib/sdk/content/worker.js", line 228, in portEmit
    self._addonWorker._onContentScriptEvent.apply(self._addonWorker, arguments);
  File "resource://jid0-edalmuivkozlouyij0lpdx548bc-at-jetpack/addon-sdk/lib/sdk/content/worker.js", line 560, in _onContentScriptEvent
    this._port._emit.apply(this._port, arguments);
  File "resource://jid0-edalmuivkozlouyij0lpdx548bc-at-jetpack/addon-sdk/lib/sdk/deprecated/events.js", line 123, in _emit
    return this._emitOnObject.apply(this, args);
  File "resource://jid0-edalmuivkozlouyij0lpdx548bc-at-jetpack/addon-sdk/lib/sdk/deprecated/events.js", line 153, in _emitOnObject
    listener.apply(targetObj, params);
  File "resource://jid0-edalmuivkozlouyij0lpdx548bc-at-jetpack/geckoprofiler/lib/main.js", line 1790, in ff_init/<
    open_settings();
  File "resource://jid0-edalmuivkozlouyij0lpdx548bc-at-jetpack/geckoprofiler/lib/main.js", line 1053, in open_settings
    onClose: function close() {
TypeError: tabs.open is not a function

Alternatively creating a stub extension that uses tabs.open should also reproduce the bug.

Comment 1

[(not currently active) Ted Mielczarek]

I'm seeing this on Windows as well.

Comment 2

[(no longer active)]

Alice, any chance you could please bisect this?

Comment 3

[Benoit Girard (:BenWa)]

It's working on mac with '20.0a1 (2013-01-05)'. Was the regression fixed?

Ted does it work on windows with the latest nightly?

Comment 4

[(not currently active) Ted Mielczarek]

It's working for me with today's Windows nightly.

Comment 5

[Alice0775 White]

Fixed window(m-i)
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/c42fa8f9377e
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20130102 Firefox/20.0 ID:20130102144249
Fixed
http://hg.mozilla.org/integration/mozilla-inbound/rev/fcab6193a0fa
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20130102 Firefox/20.0 ID:20130102153043
Fixed pishlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=c42fa8f9377e&tochange=fcab6193a0fa

Fixed by: Bug 826037

Comment 6

[(no longer active)]

(In reply to Alice0775 White from comment #5)
> Fixed window(m-i)
> Bad:
> http://hg.mozilla.org/integration/mozilla-inbound/rev/c42fa8f9377e
> Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20130102 Firefox/20.0
> ID:20130102144249
> Fixed
> http://hg.mozilla.org/integration/mozilla-inbound/rev/fcab6193a0fa
> Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20130102 Firefox/20.0
> ID:20130102153043
> Fixed pishlog:
> http://hg.mozilla.org/integration/mozilla-inbound/
> pushloghtml?fromchange=c42fa8f9377e&tochange=fcab6193a0fa
> 
> Fixed by: Bug 826037

This is misleading, since for a period since bug 818800 landed and before bug 826037 landed, Jetpack add-ons were completely broken, so you can't try to reproduce the Tabs.open exception there.  Bisecting this range requires one to apply the patches in bug 826037 for anything in that range, but that may not be worth anybody's time... :/