Closed Bug 826529 Opened 8 years ago Closed 6 years ago

Improve handling of video bitrate and resolution

Categories

(Core :: WebRTC: Audio/Video, defect)

Product:
Core
Component:
WebRTC: Audio/Video
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: ekr, Assigned: jesup)

Details

Attachments

(1 file)

Increase default video bitrate
1.17 KB, patch
jesup
: review+
Details | Diff | Splinter Review 
No description provided.
Comment on attachment 697714 [details] [diff] [review]
Increase default video bitrate

Review of attachment 697714 [details] [diff] [review]:
-----------------------------------------------------------------

Jesup, thoughts?
Attachment #697714 - Flags: feedback?(rjesup)
Comment on attachment 697714 [details] [diff] [review]
Increase default video bitrate

Review of attachment 697714 [details] [diff] [review]:
-----------------------------------------------------------------

Good for now; half tempted to take them from config vars - but that's more work.  File a followup or do a [leave-open] on this
Attachment #697714 - Flags: feedback?(rjesup) → review+
Whiteboard: [leave-open]
Should the bitrate bounds scale with the resolution?
I'm sure it should be much improved, which is why it's set to be leaveopen. If you want to do a better job, that would be awesome.
Ok. I wasn't sure if the 2.5 Mbps max would let the encoder scale up as appropriate.
No idea. I just used the same defaults as Chrome uses. This was a quick hack....
Assignee: ekr → rjesup
Summary: Increase default video bitrate → Improve handling of video bitrate and resolution
Whiteboard: [leave-open] → [WebRTC] [blocking-webrtc-]
Overtaken by events
Status: NEW → RESOLVED
Closed: 6 years ago
QA Contact: jsmith
Resolution: --- → WORKSFORME
Whiteboard: [WebRTC] [blocking-webrtc-]
You need to log in before you can comment on or make changes to this bug.