826534 - [traceback] TypeError: %d format: a number is required, not unicode

Status: VERIFIED FIXED

(Marketplace Graveyard :: Validation, defect)

Description

[krupa raj[:krupa]]

Attachment: test app

steps to reproduce:
1. Load https://marketplace-dev.allizom.org/developers/submit/app/manifest
2. Upload the attached packaged app


observed behavior:
Upload fails with "Unexpected error while validating"


Traceback details:
"Traceback (most recent call last):
  File "/data/www/addons-dev.allizom.org/zamboni/mkt/developers/tasks.py", line 55, in validator
    validation_result = run_validator(upload.path)
  File "/data/www/addons-dev.allizom.org/zamboni/mkt/developers/tasks.py", line 114, in run_validator
    spidermonkey=settings.SPIDERMONKEY)
  File "/data/www/addons-dev.allizom.org/venv/src/app-validator/appvalidator/validate.py", line 65, in validate_packaged_app
    submain.prepare_package(bundle, path, timeout)
  File "/data/www/addons-dev.allizom.org/venv/src/app-validator/appvalidator/submain.py", line 63, in prepare_package
    test_package(err, package, path)
  File "/data/www/addons-dev.allizom.org/venv/src/app-validator/appvalidator/submain.py", line 89, in test_package
    output = test_inner_package(err, package)
  File "/data/www/addons-dev.allizom.org/venv/src/app-validator/appvalidator/submain.py", line 121, in test_inner_package
    test_func(err, package)
  File "/data/www/addons-dev.allizom.org/venv/src/app-validator/appvalidator/testcases/webappbase.py", line 218, in test_app_resources
    test_icon(err, data=StringIO(icon_data), url=url, size=icon_size)
  File "/data/www/addons-dev.allizom.org/venv/src/app-validator/appvalidator/testcases/webappbase.py", line 174, in test_icon
    "[Purported] %dpx icon (%s)" % (size, url),
TypeError: %d format: a number is required, not unicode
"

Comment 1

[Matt Basta [:basta]]

Done:

https://github.com/mozilla/zamboni/commit/043dad6108aace9540b6fb66f8a8f6aa9a27204f

Comment 2

[krupa raj[:krupa]]

The attached app passes validation without tracebacking. See https://marketplace-dev.allizom.org/developers/upload/7ae8d2938398443198ab4aadb0bfd232