Closed Bug 826552 Opened 7 years ago Closed 6 years ago

Defect - Add an indicator for the title (Bookmarks, History, Remote tabs) on start page

Categories

(Firefox for Metro Graveyard :: Firefox Start, defect, P2)

x86
Windows 8.1
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ywang, Assigned: ally)

References

Details

(Whiteboard: feature=defect c=firefox_start u=metro_firefox_user p=1)

Attachments

(2 files)

Currently, tapping/clicking on the titles on start page will take users to full page of the selected section. 

But there is no clear affordance to indicate that action. So, we need to add an indicator behind the label. It looks like ">" (Attaching a screencast from Windows Store App)

I assume using this indicator does not require a graphic.
Whiteboard: [metro-mvp?]
Product: Firefox → Firefox for Metro
Whiteboard: [metro-mvp?] → [metro-mvp][LOE:1]
Bookmarks and History screens are out for v1. That means this is too.
Whiteboard: [metro-mvp][LOE:1] → [metro-mvp-][LOE:1]
Blocks: 826554
Blocks: metrov2planning
No longer blocks: 826554
Whiteboard: [metro-mvp-][LOE:1]
Component: General → Firefox Start
Asa, remember they are accessible on the snapped start screen, they are readonly, and we had a really long conversation about this n weeks ago at the monday meeting.
Oh, right; for the Snapped view. OK.
Assignee: nobody → ally
Duplicate of this bug: 881994
Attached patch clean upSplinter Review
this patch
- removes access to the panel views from the main start screen (a request of Asa's that I thought was already done)
- Adds a '>' to the snapped titles to indicate that there is a view behind them, and a localization note.
- Remove a reference to the download panel in the panel switcher view (not supposed to be there. That panel's been pulled entirely)

After this, access to the panels should be restricted to the snapped view
Attachment #761710 - Flags: review?(rsilveira)
Comment on attachment 761710 [details] [diff] [review]
clean up

Review of attachment 761710 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!
Attachment #761710 - Flags: review?(rsilveira) → review+
Keywords: checkin-needed
Hi Ally, does this work bug need to be moved out of V2 Triage?  If so, what Bug ID should it block?
Flags: needinfo?(ally)
https://hg.mozilla.org/mozilla-central/rev/29955d1e0844
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Marco, I think the duplicate bug blocked a snap story. It should probably move out of triage, as it has landed. :)
Flags: needinfo?(ally)
Hi Ally.  Thanks for the update.  I'll treat this one as the duplicate defect.  Just reopening it temporarily to add and then I'll resolve again.
Blocks: 831919, metrov1it9
No longer blocks: metrov2planning
Status: RESOLVED → REOPENED
Priority: -- → P2
QA Contact: jbecerra
Resolution: FIXED → ---
Summary: Add an indicator for the title (Bookmarks, History, Remote tabs) on start page → Defect - Add an indicator for the title (Bookmarks, History, Remote tabs) on start page
Whiteboard: feature=defect c=firefox_start u=metro_firefox_user p=1
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
Went through the following "Defect" for iteration #9 testing without any issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-07-08-03-11-14-mozilla-central/

- Went through the points from comment 5 and ensured everything worked as described
- Ensured that everything behaved the same in "Filled" view as it did in "Full Screen" view
- Ensured that the the ">" indicator appears under "Snapped" view and taping on them accesses the correct panels
- Ensured that selecting the websites from the "Bookmarks", "Recent History" & "Remote Tabs" panels works without any issues

Possible issue:

The download button is still visible on the "Navigation App Bar", making it possible to access the "Bookmarks", "Recent History" & "Download" panels even though there shouldn't be any reference to them under the awesome screen as described in comment 5. Yuan, should the "Download" button be removed?
Flags: needinfo?(ywang)
(In reply to Kamil Jozwiak [:kjozwiak] from comment #12)
> Went through the following "Defect" for iteration #9 testing without any
> issues. Used the following build:
> 
> http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-07-08-03-11-14-
> mozilla-central/
> 
> - Went through the points from comment 5 and ensured everything worked as
> described
> - Ensured that everything behaved the same in "Filled" view as it did in
> "Full Screen" view
> - Ensured that the the ">" indicator appears under "Snapped" view and taping
> on them accesses the correct panels
> - Ensured that selecting the websites from the "Bookmarks", "Recent History"
> & "Remote Tabs" panels works without any issues
> 
> Possible issue:
> 
> The download button is still visible on the "Navigation App Bar", making it
> possible to access the "Bookmarks", "Recent History" & "Download" panels
> even though there shouldn't be any reference to them under the awesome
> screen as described in comment 5. Yuan, should the "Download" button be
> removed?

Yes, you are correct, Kamil.

For V1, the download button is only visible when there is ongoing downloads. And tapping on the download icon should take the users to the Windows 8 system download folder in File. This is documented in the spec under Bug 876023.

CCed Marina(emtwo) here, to remind her change the behavior of download icon while completing the download story.
Flags: needinfo?(ywang)
Went through the following "Defect" for iteration #10 testing without any issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-07-19-03-02-04-mozilla-central/

- Went through the points from comment 5 and ensured everything worked as described
- Went through the test cases added in comment 12 without any issues

The panels are still accessible if you select the "Download" icon, but has been addressed by Yuan in comment 13
Hi Yuan,
Where i should check this indicator ">". I opened start screen  and don't see any indicator.
I see content as below:
Top Sites
Bookmarks 
Recent History 

Should it be as below:
Top Sites >
Bookmarks >
Recent History >
Flags: needinfo?(ywang)
Samvedana, as per comments 1, 2 and 3, the indicators only show up in snapped view.
Flags: needinfo?(ywang)
Went through the following "Defect" for iteration #15 without any issues (touch device ). Used the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-10-15-03-03-19-mozilla-central/

- Went through the original story from comment #0 without any issues
- Went through all the points from comment #5 and ensured everything behaves and appears correctly
- Went through the test cases from comment #12 without any issues
- Ensured that you cannot access the download panel anymore (or any other panels)
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.