826559 - [traceback] UndefinedError: 'None' has no attribute 'get_absolute_url'

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Add-on Builder, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

I'm hitting a 500 when trying to access this URL:

https://builder.addons.mozilla.org/package/165870/latest/

Traceback (most recent call last):

  File "/data/www/builder.addons.mozilla.org/flightdeck/vendor/lib/python/django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/www/builder.addons.mozilla.org/flightdeck/apps/jetpack/views.py", line 139, in view_or_edit
    return view(request, revision)

  File "/data/www/builder.addons.mozilla.org/flightdeck/apps/jetpack/views.py", line 199, in view
    'tree': tree

  File "/data/www/builder.addons.mozilla.org/flightdeck/utils/helpers.py", line 77, in render
    *args, **kwargs)

  File "/data/www/builder.addons.mozilla.org/flightdeck/vendor/lib/python/django/shortcuts/__init__.py", line 20, in render_to_response
    return HttpResponse(loader.render_to_string(*args, **kwargs), **httpresponse_kwargs)

  File "/data/www/builder.addons.mozilla.org/flightdeck/vendor/lib/python/django/template/loader.py", line 188, in render_to_string
    return t.render(context_instance)

  File "/data/www/builder.addons.mozilla.org/flightdeck/vendor/src/jingo/jingo/__init__.py", line 189, in render
    return super(Template, self).render(context_dict)

  File "/data/www/builder.addons.mozilla.org/flightdeck/vendor/lib/python/jinja2/environment.py", line 891, in render
    return self.environment.handle_exception(exc_info, True)

  File "/data/www/builder.addons.mozilla.org/flightdeck/apps/jetpack/templates/addon_view.html", line 1, in top-level template code
    {% extends "view.html" %}

  File "/data/www/builder.addons.mozilla.org/flightdeck/apps/jetpack/templates/view.html", line 1, in top-level template code
    {% extends "base_fluid_width.html" %}

  File "/data/www/builder.addons.mozilla.org/flightdeck/apps/base/templates/base_fluid_width.html", line 1, in top-level template code
    {% extends "base.html" %}

  File "/data/www/builder.addons.mozilla.org/flightdeck/apps/base/templates/base.html", line 79, in top-level template code
    {% block base_fluid_width %}

  File "/data/www/builder.addons.mozilla.org/flightdeck/apps/base/templates/base_fluid_width.html", line 5, in block "base_fluid_width"
    {% block app_sidebar %}{%endblock %}

  File "/data/www/builder.addons.mozilla.org/flightdeck/apps/jetpack/templates/view.html", line 70, in block "app_sidebar"
    {% block core_library %}{% endblock %}

  File "/data/www/builder.addons.mozilla.org/flightdeck/apps/jetpack/templates/addon_view.html", line 33, in block "core_library"
    <a href="{{ revision.get_sdk_revision().get_absolute_url() }}" target="_blank">

UndefinedError: 'None' has no attribute 'get_absolute_url'

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

This is actually critical, a lot more widespread than I first thought: http://pastie.org/5623733

Comment 3

[Piotr Zalewa [:zalun]]

This is fixed in -dev 
https://github.com/mozilla/FlightDeck/commit/74d4dd6dd7262928269fd7327ae5b28affb5783b 
https://github.com/mozilla/FlightDeck/commit/f57f3514db9886f854bc7d554ff55d6c77ba71bf
Awaiting push to production

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; thanks!