826589 - Apps in activity selector are not using translated name

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect, P3)

Description

[(inactive after 6/18) Alive Kuo [:alive]]

STR:

1. Change the language to non-English
2. Use any activity
* Long press home
* Click share in Gallery app

Expected:
* The app names are translated when you are choosing the activity target

Actual:
* The app names are in English

Note:
* There's another bug in activity: the name of activity action is not translated.
* e.g. pick in selecting wallpaper case. I'll file another bug for this.

Comment 1

[Joe Cheng [:jcheng] (please needinfo)]

Triage: BB+, C4, p3

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Make sure to use the new ManifestHelper object.

Comment 4

[chris hofmann]

so is this a localization fix, or will using the ManifestHelper object end up getting the right strings and resolve?

Comment 5

[Etienne Segonzac (:etienne)]

Alive, can I steal this? :)

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

I'd like to say yes because this seems a platform issue.

ActivitiesGlue doesn't provide identifier to app but a translated English name of the app.
Also, it doesn't deal with entry points. That means, we get 'Communications' instead of 'Contact' when picking a contact info.

Notice: If activitiesGlue is willing to provide origin to system app, WindowManager has working function to get the translated name. Just reference the name field in runningApps.

(In reply to Etienne Segonzac (:etienne) from comment #5)
> Alive, can I steal this? :)

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

Uh...there's very dirty solution.
Look up the translated name provided by Gecko/ActivitiesGlue in Gaia/ManifestHelper.
And then use the manifest object to fetch to localized name...but this seems too dirty because we couldn't guarantee the translated name is unique :/ Also this couldn't resolve the entry point issue.

I think Margaret would be interesting in stealing this in platform?

Comment 8

[:Margaret Leibovic]

I can take this.

Comment 9

[Etienne Segonzac (:etienne)]

(In reply to Margaret Leibovic [:margaret] from comment #8)
> I can take this.

Cool I'm in no position to steal bug anymore :)

Comment 10

[:Margaret Leibovic]

Attachment: (Part 1) Pass manifest to activity picker instead of pre-translated title

I came up with a solution that changes the gecko side of things to stop storing the app titles, and instead pass along the manifest url to gaia so that we can localize the app names when we show the activity picker.

Is there someone besides fabrice who can review this sooner?

Comment 11

[:Margaret Leibovic]

Attachment: (Part 2) Use localized app name in activity picker

Comment 12

[:Margaret Leibovic]

Comment on attachment 698673 [details] [diff] [review]
(Part 1) Pass manifest to activity picker instead of pre-translated title

Maybe Vivien wants to review this :)

Comment 13

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 698676 [details] [diff] [review]
(Part 2) Use localized app name in activity picker

Review of attachment 698676 [details] [diff] [review]:
-----------------------------------------------------------------

Looks simple and good. r=me if you have tested it ;)

Comment 14

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 698673 [details] [diff] [review]
(Part 1) Pass manifest to activity picker instead of pre-translated title

LGTM :)

Comment 15

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2f1a79af3601
https://hg.mozilla.org/releases/mozilla-b2g18/rev/3360b3e31b28
https://github.com/mozilla-b2g/gaia/commit/809cce4186716f92c431d1eebf4e831e38939194

Comment 16

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 698673 [details] [diff] [review]
(Part 1) Pass manifest to activity picker instead of pre-translated title

Review of attachment 698673 [details] [diff] [review]:
-----------------------------------------------------------------

I can't remember why saved the title in the original impl and I don't think it harms to not store it anymore.

Comment 17

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2f1a79af3601

Comment 18

[Ed Morley [:emorley]]

This missed the merge for mozilla20 - reflecting in flags.

(Also, normally bugs are left open until they merge to mozilla-central :-))