Enable warnings-as-errors on tryserver for MSVC

RESOLVED INVALID

Status

Firefox Build System
General
RESOLVED INVALID
5 years ago
2 months ago

People

(Reporter: emk, Unassigned)

Tracking

Trunk
All
Windows 8

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

5 years ago
If it was enabled, it would have caught the build failure of bug 805591 earlier.

Comment 1

5 years ago
Tinderbox Configuration is an obsolete component, moving.

Try builds use the in-tree mozconfig. Looking at the try log:
{
========= Started got mozconfig (results: 0, elapsed: 0 secs) (at 2013-01-03 09:18:56.153223) =========
'python' 'e:/builds/moz2_slave/try-w32/tools/buildfarm/utils/retry.py' '-s' '1' '-r' '5' '-t' '1260' 'bash' '-c' 'if [ -f "browser/config/mozconfigs/win32/nightly" ]; then                        echo Using in-tree mozconfig;                        cp browser/config/mozconfigs/win32/nightly .mozconfig;                    else                        echo Downloading mozconfig;                        wget -O .mozconfig http://hg.mozilla.org/build/buildbot-configs/raw-file/production/mozilla2/win32/try/nightly/mozconfig;                    fi'
...
...
}

and 

{
========= Started 'cat .mozconfig' (results: 0, elapsed: 0 secs) (at 2013-01-03 09:18:56.771882) =========
. "$topsrcdir/browser/config/mozconfigs/common"

# for pgo
mk_add_options PROFILE_GEN_SCRIPT='$(PYTHON) $(MOZ_OBJDIR)/_profile/pgo/profileserver.py'

ac_add_options --enable-update-channel=${MOZ_UPDATE_CHANNEL}
ac_add_options --enable-update-packaging
ac_add_options --enable-jemalloc
ac_add_options --enable-signmar
ac_add_options --enable-profiling

# Nightlies only since this has a cost in performance
ac_add_options --enable-js-diagnostics

# Needed to enable breakpad in application.ini
export MOZILLA_OFFICIAL=1

export MOZ_TELEMETRY_REPORTING=1

if test -z "${_PYMAKE}"; then
  mk_add_options MOZ_MAKE_FLAGS=-j1
fi

if test "$PROCESSOR_ARCHITECTURE" = "AMD64" -o "$PROCESSOR_ARCHITEW6432" = "AMD64"; then
  . $topsrcdir/build/win32/mozconfig.vs2010-win64
else
  . $topsrcdir/build/win32/mozconfig.vs2010
fi

# Package js shell.
export MOZ_PACKAGE_JSSHELL=1

. "$topsrcdir/build/mozconfig.common.override"
program finished with exit code 0
elapsedTime=0.108000
========= Finished 'cat .mozconfig' (results: 0, elapsed: 0 secs) (at 2013-01-03 09:18:56.896341) =========
}

...ie the mozconfig used doesn't include the recent mozconfig changes.

This is because the try run wasn't rebased.

Qparent is:
https://hg.mozilla.org/try/rev/33064e13c3fd

Whereas the warnings-as-errors changes landed in:
https://hg.mozilla.org/mozilla-central/rev/4983b42d58c9
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Component: Tinderbox Configuration → Build Config
Product: mozilla.org → Core
Resolution: --- → INVALID
Version: other → Trunk

Updated

5 years ago
Blocks: 824247

Updated

2 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.