Closed Bug 826683 Opened 11 years ago Closed 11 years ago

BaselineCompiler: attach type update stubs

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jandem, Assigned: jandem)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

      No description provided.
Attached patch PatchSplinter Review
This is very similar to the monitor stubs.
Attachment #697901 - Flags: review?(kvijayan)
Comment on attachment 697901 [details] [diff] [review]
Patch

Review of attachment 697901 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.  Do you notice perf improvements with these in?
Attachment #697901 - Flags: review?(kvijayan) → review+
https://hg.mozilla.org/projects/ionmonkey/rev/300b2b81e917

(In reply to Kannan Vijayan [:djvj] from comment #2)
> 
> Nice.  Do you notice perf improvements with these in?

The slow path didn't actually add the type without this patch, so it's hard to say, but if we never attach type update stubs perf regresses from 830 to 1020 ms on SS.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: