826772 - French locale is wrong for the update notification

Status: RESOLVED FIXED

(Mozilla Localizations :: fr / French, defect)

Description

[Julien Wajsberg [:julienw]]

STR:
* have a system update (for example: flash a custom build)
* start the download

It's written : "XXX Mo téléchargées" whereas it should be "XXX Mo téléchargés".

Comment 1

[Théo Chevalier]

Oh, thanks, the two labels weren’t clear to me, where the first one is about the number of updates and the second one about their size.

apps ⊃ system.properties ⊃ downloadingAppProgressNoMax 	{{ progress }} downloaded {{ progress }} téléchargées

apps ⊃ system.properties ⊃ downloadingAppProgress {{ progress }} / {{ max }} downloaded 	{{ progress }} / {{ max }} téléchargées

https://hg.mozilla.org/gaia-l10n/fr/rev/a5e969c80cc9

Also fixed plural forms :)

Comment 2

[Julien Wajsberg [:julienw]]

Mmm I think that's not right (except your fix for updatesAvailableMessage). Sorry it may be my fault, I'm sometimes not clear enough :)

{{ progress }} is something like "5 Mo" so because "octet" is masculine gender, it should be  "téléchargés" and this can't be plural because "progress" is not a number.

This is true for "downloadingAppProgressNoMax", "downloadingUpdateMessage" and "downloadingAppProgress".

Sorry about that :/

Comment 3

[Théo Chevalier]

Attachment: Patch

You don’t have to be sorry, is it what you mean?

Comment 4

[Julien Wajsberg [:julienw]]

Comment on attachment 698138 [details] [diff] [review]
Patch

Review of attachment 698138 [details] [diff] [review]:
-----------------------------------------------------------------

Yep that's it !

I let you choose for the final period.

::: apps/system/system.properties
@@ +89,5 @@
>  wantToDownload=Télécharger une mise à jour maintenant ?
>  wantToInstall=Installer la mise à jour maintenant ?
>  installNow=Installer maintenant
>  # the <span> element will be displayed when the download finishes
> +downloadingUpdateMessage=Téléchargement des mises à jour… <span>{{ progress }} téléchargés.</span>

I'm not sure about the final period.

Comment 5

[Théo Chevalier]

(In reply to Julien Wajsberg [:julienw] from comment #4)
> Comment on attachment 698138 [details] [diff] [review]
> Patch
> 
> Review of attachment 698138 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Yep that's it !
> 
> I let you choose for the final period.
> 
> ::: apps/system/system.properties
> @@ +89,5 @@
> >  wantToDownload=Télécharger une mise à jour maintenant ?
> >  wantToInstall=Installer la mise à jour maintenant ?
> >  installNow=Installer maintenant
> >  # the <span> element will be displayed when the download finishes
> > +downloadingUpdateMessage=Téléchargement des mises à jour… <span>{{ progress }} téléchargés.</span>
> 
> I'm not sure about the final period.

Hm, yes, not really meaningful here, but I think we should be consistent with <span>Toucher pour télécharger.</span> (Benoit?)

Btw, without you I can easily say that this issue might have been here for a pretty long time, if you see anything else, please file

https://hg.mozilla.org/gaia-l10n/fr/rev/206a6f2ac655

Comment 6

[Benoit]

(In reply to Théo Chevalier [:tchevalier] from comment #5)
> Hm, yes, not really meaningful here, but I think we should be consistent
> with <span>Toucher pour télécharger.</span> (Benoit?)

I agree with the period. According to the above comment, the span part is displayed when the download finishes. So that closes the action, and the period just feels natural to underline this.

Comment 7

[Julien Wajsberg [:julienw]]

Agreed for this one, but not for :

downloadingUpdateMessage=Téléchargement des mises à jour… <span>{{ progress }} téléchargés.</span>

Comment 8

[Julien Wajsberg [:julienw]]

I mean this is not consistent with the other similar messages (which have "{{ progress }} téléchargés" too) that don't have this period.

Comment 9

[Benoit]

(In reply to Julien Wajsberg [:julienw] from comment #8)
> I mean this is not consistent with the other similar messages (which have
> "{{ progress }} téléchargés" too) that don't have this period.

Aren't the other ones progress messages that update dynamically? 

At that point the numbers are not final, so it makes sense not to close the sentence yet.

(not that I think it is of uttermost importance, most people wouldn't notice either way)

Comment 10

[Julien Wajsberg [:julienw]]

Exactly, in the case of "downloadingUpdateMessage=Téléchargement des mises à jour… <span>{{ progress }} téléchargés.</span>", the numbers are not final...

Comment 11

[Benoit]

Just above the definition of downloadingUpdateMessage, there is this comment:

# the <span> element will be displayed when the download finishes

As I understand this comment, the contents of the span element will NOT be displayed until the numbers are final. Either that, or the comment is highly misleading and should be updated to explain how things really work.

Comment 12

[Julien Wajsberg [:julienw]]

Now I understand, I didn't pay attention to the comment at all.

I'm quite sure the comment is wrong now. However, I see that the period is also in the english locale so let's stop here for that, we'll change it in french when it will be changed in english.

Thanks !

Comment 13

[Julien Wajsberg [:julienw]]

filed bug 827088.