826896 - Update gaiatest mozharness script to set DM_TRANS and TEST_DEVICE env variables

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect, P1)

Description

[Jonathan Griffin (:jgriffin)]

There's a pull request pending for gaia-ui-tests that allows them to populate media files using devicemanager prior to test, see: https://github.com/mozilla/gaia-ui-tests/pull/236/files

In order for this to work, we'll need to set DM_TRANS='sut' and TEST_DEVICE=(ip of panda) before invoking gaiatest.

Comment 1

[Armen [:armenzg]]

Attachment: adjust env for gaia ui tests

Aki, is there a way to show on the logs that these env variables have been set?

The current logs do not show any env changes.

Perhaps this should be configuration value rather than modified in the code?
Do we dump env variables on mozharness? I can't seem to find that.

Comment 2

[Aki Sasaki (not active)]

Comment on attachment 698768 [details] [diff] [review]
adjust env for gaia ui tests

+        env = self.query_env()
+        env["DM_TRANS"] = "sut"
+        env["TEST_DEVICE"] = self.mozpool_device

This is equivalent to

env = self.query_env(partial_env={'DM_TRANS': 'sut', 'TEST_DEVICE': self.mozpool_device})

Comment 3

[Aki Sasaki (not active)]

(In reply to Armen Zambrano G. [:armenzg] from comment #1)
> Aki, is there a way to show on the logs that these env variables have been
> set?
> 
> The current logs do not show any env changes.
> 
> Perhaps this should be configuration value rather than modified in the code?
> Do we dump env variables on mozharness? I can't seem to find that.

There isn't, currently.

I've been meaning to echo env settings to the log, but have been putting it off since android signing can use env vars for passphrases.  I thought about making the env logging configurable, but haven't gotten to it.

If this would be helpful here, I can revisit (or point you to where/how to make the changes).

Comment 4

[Armen [:armenzg]]

Comment on attachment 698768 [details] [diff] [review]
adjust env for gaia ui tests

http://hg.mozilla.org/build/mozharness/rev/740e75fc5af5

Comment 5

[Armen [:armenzg]]

Feel free to throw mozharness work at me and see where I can help.