Closed Bug 826959 Opened 12 years ago Closed 11 years ago

Disable the bogus MSVC warning C4355

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
All
Windows 8
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: emk, Unassigned)

References

(
URL
)

Details

>+// We know DecodeRequest won't touch members of RasterImage
>+// until this constructor completes
>+#ifdef _MSC_VER
>+#pragma warning(push)
>+#pragma warning(disable : 4355)
>+#endif
>   mDecodeRequest(this),
>+#ifdef _MSC_VER
>+#pragma warning(pop)
>+#endif

:(
I was suggested disabling the warning globally in bug 827032.
Morphing this bug for that purpose.
Component: ImageLib → Build Config
URL: http://connect.microsoft.com/VisualSt...
Summary: Refactor RasterImage and/or DecodeRequest to make the initializer less sucky → Disable the bogus MSVC warning C4355
Blocks: 827032
People have been working around this using 

  ALLOW_THIS_IN_INITIALIZER_LIST(this)
  
Apparently the Visual Studio team is disabling this warning going forward (or I'm a victim of an internet imposter):

  http://connect.microsoft.com/VisualStudio/feedback/details/718050

So perhaps we should just disable it and get rid of the macro ugliness.
No longer blocks: 827032
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.