826969 - Correct batching in bookmarks engine

Status: RESOLVED INVALID

(Firefox :: Sync, defect)

Description

[Richard Newman [:rnewman]]

************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'JavaScript component does not have a method named: "batching"' when calling method: [nsINavHistoryResultObserver::batching]"  nsresult: "0x80570030 (NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED)"  location: "JS frame :: resource://services-sync/engines/bookmarks.js :: _sync :: line 218"  data: no]


…

    // Try running sync in batch mode
    PlacesUtils.bookmarks.runInBatchMode({
      runBatched: function wrappedSync() {
        try {
          SyncEngine.prototype._sync.call(engine);
        }
        catch(ex) {
          batchEx = ex;
        }
      }
    }, null);

Comment 1

[Marco Bonardo [:mak]]

the implementations I know are:
http://mxr.mozilla.org/mozilla-central/source/browser/components/places/content/browserPlacesViews.js
http://mxr.mozilla.org/mozilla-central/source/browser/components/places/content/treeView.js
http://mxr.mozilla.org/mozilla-central/source/browser/components/downloads/content/allDownloadsViewOverlay.js

and all of them have batching

Comment 2

[Sunny [:darkowlzz]]

Hi, I would like to work on this bug. 
I need some more details about the bug. From the above comments, it's not clear what and how to do?

Please guide me on how to fix this bug and understand various things related to it.

Comment 3

[Richard Newman [:rnewman]]

(In reply to darkowlzz from comment #2)
> Hi, I would like to work on this bug. 
> I need some more details about the bug. From the above comments, it's not
> clear what and how to do?
> 
> Please guide me on how to fix this bug and understand various things related
> to it.

The first thing to do is to watch console output while syncing bookmarks in a profile on Nightly.

  http://nightly.mozilla.org/

If you don't see the log output from Comment 0, great; we can close this bug.

If you do see that output, you need to start following the steps here:

  https://developer.mozilla.org/docs/Introduction

particularly 

  https://developer.mozilla.org/docs/Simple_Firefox_build
  https://developer.mozilla.org/docs/Developer_Guide
  https://developer.mozilla.org/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

When you've got a working build, and can generate patches in a patch queue, come back here and we'll talk about how to figure out this bug!

Thanks!

Comment 4

[Sunny [:darkowlzz]]

I already have a working build and I have also learnt to create patches using mq.
We can talk about how to figure out the bug.

Comment 5

[Richard Newman [:rnewman]]

(In reply to darkowlzz from comment #4)

> We can talk about how to figure out the bug.

OK, so does it repro?

Comment 6

[Sunny [:darkowlzz]]

(In reply to Richard Newman [:rnewman] from comment #5)
> (In reply to darkowlzz from comment #4)
> 
> > We can talk about how to figure out the bug.
> 
> OK, so does it repro?

I guess, no. I get just this in Error Console.

phx-sync408.services.mozilla.com : server does not support RFC 5746, see CVE-2009-3555

Comment 7

[Josiah Bruner [:jsbruner]]

My output is almost identical to darkowlzz. 

phx-sync598.services.mozilla.com : server does not support RFC 5746, see CVE-2009-3555

Comment 8

[Richard Newman [:rnewman]]

Great! Thanks for verifying. No work to do here, so please move on to the next thing! :D