Closed
Bug 826996
Opened 11 years ago
Closed 11 years ago
Avoid hardcoded value for {moz:official} in search plugins
Categories
(Toolkit :: General, defect)
Toolkit
General
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: glandium, Assigned: glandium)
Details
Attachments
(1 file, 1 obsolete file)
4.50 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
We currently have the following in nsSearchService.js: #ifdef MOZ_OFFICIAL_BRANDING const MOZ_OFFICIAL = "official"; #else const MOZ_OFFICIAL = "unofficial"; #endif Building Firefox as a xulrunner application makes it having to choose between all xulrunner applications expanding {moz:official} to either "official" or "unofficial". This should be chosen at the application level.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #698253 -
Flags: review?(dtownsend+bugmail)
Comment 2•11 years ago
|
||
Comment on attachment 698253 [details] [diff] [review] Avoid hardcoded value for {moz:official} in search plugins Looks ok to me but I'd like gavin's eyes on it
Attachment #698253 -
Flags: review?(dtownsend+bugmail) → review?(gavin.sharp)
Comment 3•11 years ago
|
||
Apps needing to remember to opt-in is a bit of a downside to this. How about leaving the build-time preprocessing for the default value in nsSearchService?
Comment 4•11 years ago
|
||
Comment on attachment 698253 [details] [diff] [review] Avoid hardcoded value for {moz:official} in search plugins I think having the default in toolkit continue to depend on the build-time branding would be better, to protect against an app forgetting to opt-in to this behavior in the common case of it being built "standalone" rather than XULRunner-dependent.
Attachment #698253 -
Flags: review?(gavin.sharp) → feedback+
Assignee | ||
Comment 5•11 years ago
|
||
Attachment #700227 -
Flags: review?(gavin.sharp)
Assignee | ||
Updated•11 years ago
|
Attachment #698253 -
Attachment is obsolete: true
Updated•11 years ago
|
Attachment #700227 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Comment 6•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a4d691c7bacb
Comment 7•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a4d691c7bacb
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•