827031 - [toolbox] Background color in checked state of toolbox command buttons should be similar to active state.

Status: RESOLVED FIXED

(DevTools :: Framework, defect, P2)

Description

[Girish Sharma [:Optimizer]]

Attachment: screenshot

This is coming from rule :

toolbarbutton[checked="true"]:not([disabled="true"]) {
  border-color: ThreeDShadow ThreeDHighlight ThreeDHighlight ThreeDShadow;
  padding-top: 4px;
  padding-bottom: 2px;
  -moz-padding-start: 4px;
  -moz-padding-end: 2px;
  background-color: rgba(255,255,255,0.5);
  color: ButtonText;
}

from file

chrome://global/skin/toolbarbutton.css

I am sure it is not intended.

Comment 1

[Girish Sharma [:Optimizer]]

Attachment: patch v1.0

Making the background color same as active state.

Comment 2

[Girish Sharma [:Optimizer]]

Attachment: screenshot of patch v1.0 in action

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/eddf3a4a9d49

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/mozilla-central/rev/eddf3a4a9d49

Comment 5

[Victor Porof [:vporof][:vp]]

Attachment: os x

There's still a left|right border on OS X, intended?

Comment 6

[Girish Sharma [:Optimizer]]

(In reply to Victor Porof [:vp] from comment #5)
> Created attachment 698590 [details]
> os x
> 
> There's still a left|right border on OS X, intended?

Was this introduced by this bug ?
I don't have OSX so I can't know.

Comment 7

[Victor Porof [:vporof][:vp]]

Filed bug 827265.