Closed Bug 827031 Opened 7 years ago Closed 7 years ago

[toolbox] Background color in checked state of toolbox command buttons should be similar to active state.

Categories

(DevTools :: Framework, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 20

People

(Reporter: Optimizer, Assigned: Optimizer)

Details

Attachments

(4 files)

Attached image screenshot
This is coming from rule :

toolbarbutton[checked="true"]:not([disabled="true"]) {
  border-color: ThreeDShadow ThreeDHighlight ThreeDHighlight ThreeDShadow;
  padding-top: 4px;
  padding-bottom: 2px;
  -moz-padding-start: 4px;
  -moz-padding-end: 2px;
  background-color: rgba(255,255,255,0.5);
  color: ButtonText;
}

from file

chrome://global/skin/toolbarbutton.css

I am sure it is not intended.
Summary: [toolbox] Checked state of checkbox type buttons in toolbox have background color white. → [toolbox] Background color in checked state of toolbox command buttons should be similar to active state.
Attached patch patch v1.0Splinter Review
Making the background color same as active state.
Assignee: nobody → scrapmachines
Status: NEW → ASSIGNED
Attachment #698308 - Flags: review?(paul)
OS: Windows 7 → All
Priority: -- → P2
Hardware: x86_64 → All
Whiteboard: [has-patch]
Version: unspecified → Trunk
Attachment #698308 - Flags: review?(paul) → review+
Whiteboard: [has-patch] → [land-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/eddf3a4a9d49
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 20
Attached image os x
There's still a left|right border on OS X, intended?
(In reply to Victor Porof [:vp] from comment #5)
> Created attachment 698590 [details]
> os x
> 
> There's still a left|right border on OS X, intended?

Was this introduced by this bug ?
I don't have OSX so I can't know.
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.