Implement -moz-menubar and make it return the correct menubar background color on gtk

RESOLVED WONTFIX

Status

()

defect
RESOLVED WONTFIX
7 years ago
7 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

Trunk
mozilla20
x86
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox20 wontfix)

Details

Attachments

(1 attachment)

Posted patch Patch (v1)Splinter Review
We need this for bug 749394.
Attachment #698381 - Flags: review?(roc)
What happens if -moz-appearance:menubar; is used instead of background-color:-moz-menubar;-moz-appearance:none; ?
OS: Mac OS X → Linux
(In reply to comment #1)
> What happens if -moz-appearance:menubar; is used instead of
> background-color:-moz-menubar;-moz-appearance:none; ?

That would of course paint the right background color, but will make it impossible to paint a background image in that element which is what we need to do.  The point of this patch is to make it possible to paint the correct background color for the menu bar when -moz-appearance:menubar is not being used.
https://hg.mozilla.org/mozilla-central/rev/5af4c6bd5104
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
So it turns out that we didn't need this in the end, so I backed out the patch:

https://hg.mozilla.org/integration/mozilla-inbound/rev/f8c8d02f405d

Alex, should I back this out on Aurora as well?
Resolution: FIXED → WONTFIX
(In reply to :Ehsan Akhgari from comment #4)
> So it turns out that we didn't need this in the end, so I backed out the
> patch:
> 
> https://hg.mozilla.org/integration/mozilla-inbound/rev/f8c8d02f405d

Merge of backout:
https://hg.mozilla.org/mozilla-central/rev/f8c8d02f405d
(In reply to :Ehsan Akhgari from comment #4)
> So it turns out that we didn't need this in the end, so I backed out the
> patch:
> 
> https://hg.mozilla.org/integration/mozilla-inbound/rev/f8c8d02f405d
> 
> Alex, should I back this out on Aurora as well?

a=akeybl on this backout, for consistency, given where we are in the Aurora cycle
You need to log in before you can comment on or make changes to this bug.