827075 - Implement -moz-menubar and make it return the correct menubar background color on gtk

Status: RESOLVED WONTFIX

(Core :: CSS Parsing and Computation, defect)

Description

[(no longer active)]

Attachment: Patch (v1)

We need this for bug 749394.

Comment 1

[Karl Tomlinson (:karlt)]

What happens if -moz-appearance:menubar; is used instead of background-color:-moz-menubar;-moz-appearance:none; ?

Comment 2

[(no longer active)]

(In reply to comment #1)
> What happens if -moz-appearance:menubar; is used instead of
> background-color:-moz-menubar;-moz-appearance:none; ?

That would of course paint the right background color, but will make it impossible to paint a background image in that element which is what we need to do.  The point of this patch is to make it possible to paint the correct background color for the menu bar when -moz-appearance:menubar is not being used.

Comment 3

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/5af4c6bd5104

Comment 4

[(no longer active)]

So it turns out that we didn't need this in the end, so I backed out the patch:

https://hg.mozilla.org/integration/mozilla-inbound/rev/f8c8d02f405d

Alex, should I back this out on Aurora as well?

Comment 5

[Ed Morley [:emorley]]

(In reply to :Ehsan Akhgari from comment #4)
> So it turns out that we didn't need this in the end, so I backed out the
> patch:
> 
> https://hg.mozilla.org/integration/mozilla-inbound/rev/f8c8d02f405d

Merge of backout:
https://hg.mozilla.org/mozilla-central/rev/f8c8d02f405d

Comment 6

[Alex Keybl [:akeybl]]

(In reply to :Ehsan Akhgari from comment #4)
> So it turns out that we didn't need this in the end, so I backed out the
> patch:
> 
> https://hg.mozilla.org/integration/mozilla-inbound/rev/f8c8d02f405d
> 
> Alex, should I back this out on Aurora as well?

a=akeybl on this backout, for consistency, given where we are in the Aurora cycle

Comment 7

[(no longer active)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ca40e0e49a9d