Incorporate nsITransactionManager interface changes (beginBatch, endBatch)

RESOLVED FIXED in 2.2

Status

Calendar
Internal Components
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Stefan Sitter, Assigned: Stefan Sitter)

Tracking

Lightning 2.2

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Bug 617532 changed the interface of nsITransactionManager, e.g. beginBatch() and endBatch() now require parameters being passed in. We have to update our usage in Lightning, e.g. in /calendar/base/src/calTransactionManager.js.
(Assignee)

Comment 1

4 years ago
Created attachment 698447 [details] [diff] [review]
possible fix

Patch not yet tested due to current Thunderbird build errors.
Assignee: nobody → ssitter
Status: NEW → ASSIGNED
Attachment #698447 - Flags: review?(philipp)
Comment on attachment 698447 [details] [diff] [review]
possible fix

Now that the tree builds again I've tested the patch and it works as expected.

r=philipp
Attachment #698447 - Flags: review?(philipp) → review+
(Assignee)

Comment 3

4 years ago
I won't have time for checkin before evening. Fell free to take over if you want to include the fix in todays nightly build or the branch uplift.
Comment on attachment 698447 [details] [diff] [review]
possible fix

Trees are closed at the moment, I think its ok to just backport this once the merge is done and trees are open again
Attachment #698447 - Flags: approval-calendar-aurora+
(Assignee)

Updated

4 years ago
Duplicate of this bug: 829233
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
(Assignee)

Comment 6

4 years ago
Comment on attachment 698447 [details] [diff] [review]
possible fix

Pushed to https://hg.mozilla.org/comm-central/rev/125efc72f503 for Lightning 2.3.
https://hg.mozilla.org/releases/comm-aurora/rev/198ed4f01f7b
Keywords: checkin-needed
Target Milestone: --- → 2.2
(Assignee)

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.