Closed Bug 827132 Opened 7 years ago Closed 7 years ago

Incorporate nsITransactionManager interface changes (beginBatch, endBatch)

Categories

(Calendar :: Internal Components, defect)

Lightning 2.2
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ssitter, Assigned: ssitter)

References

Details

Attachments

(1 file)

Bug 617532 changed the interface of nsITransactionManager, e.g. beginBatch() and endBatch() now require parameters being passed in. We have to update our usage in Lightning, e.g. in /calendar/base/src/calTransactionManager.js.
Attached patch possible fixSplinter Review
Patch not yet tested due to current Thunderbird build errors.
Assignee: nobody → ssitter
Status: NEW → ASSIGNED
Attachment #698447 - Flags: review?(philipp)
Comment on attachment 698447 [details] [diff] [review]
possible fix

Now that the tree builds again I've tested the patch and it works as expected.

r=philipp
Attachment #698447 - Flags: review?(philipp) → review+
I won't have time for checkin before evening. Fell free to take over if you want to include the fix in todays nightly build or the branch uplift.
Comment on attachment 698447 [details] [diff] [review]
possible fix

Trees are closed at the moment, I think its ok to just backport this once the merge is done and trees are open again
Attachment #698447 - Flags: approval-calendar-aurora+
Duplicate of this bug: 829233
Keywords: checkin-needed
Comment on attachment 698447 [details] [diff] [review]
possible fix

Pushed to https://hg.mozilla.org/comm-central/rev/125efc72f503 for Lightning 2.3.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.