Closed Bug 827172 Opened 7 years ago Closed 7 years ago

Convert SVGPathElement to WebIDL

Categories

(Core :: SVG, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: dzbarsky, Assigned: dzbarsky)

References

Details

Attachments

(2 files)

No description provided.
Blocks: 827174
Assignee: nobody → dzbarsky
Attachment #699018 - Flags: review?(bzbarsky)
Comment on attachment 699018 [details] [diff] [review]
Move SVGPathElement to mozilla::dom

r=me
Attachment #699018 - Flags: review?(bzbarsky) → review+
Is there more patch coming up here, by the way?
There will be a conversion patch here when I finish it.
Attachment #701549 - Flags: review?(bzbarsky)
Blocks: 825282
Comment on attachment 701549 [details] [diff] [review]
Convert sVGPathElement to WebIDL

>+SVGPathElement::CreateSVGPathSegCurvetoCubicRel(float x, float y, float x1, float y1, float x2, float y2)

You want a comment here mentioning the comment in CreateSVGPathSegCurvetoCubicAbs.

>+SVGPathElement::CreateSVGPathSegCurvetoQuadraticAbs(float x, float y, float x1, float y1)

And here.

>+SVGPathElement::CreateSVGPathSegCurvetoQuadraticRel(float x, float y, float x1, float y1)

And here.

>+SVGPathElement::CreateSVGPathSegArcAbs(float x, float y, float r1, float r2, float angle, bool largeArcFlag, bool sweepFlag)

And here.

>+SVGPathElement::CreateSVGPathSegArcRel(float x, float y, float r1, float r2, float angle, bool largeArcFlag, bool sweepFlag)

And here.

>+SVGPathElement::CreateSVGPathSegCurvetoCubicSmoothAbs(float x, float y, float x2, float y2)

And here.

>+SVGPathElement::CreateSVGPathSegCurvetoCubicSmoothRel(float x, float y, float x2, float y2)

And here.

r=me with that
Attachment #701549 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/d00c3bba9929
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.