Closed
Bug 827172
Opened 11 years ago
Closed 11 years ago
Convert SVGPathElement to WebIDL
Categories
(Core :: SVG, defect)
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: dzbarsky, Assigned: dzbarsky)
References
Details
Attachments
(2 files)
32.96 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
41.23 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → dzbarsky
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #699018 -
Flags: review?(bzbarsky)
Comment 2•11 years ago
|
||
Comment on attachment 699018 [details] [diff] [review] Move SVGPathElement to mozilla::dom r=me
Attachment #699018 -
Flags: review?(bzbarsky) → review+
Comment 3•11 years ago
|
||
Is there more patch coming up here, by the way?
Assignee | ||
Comment 4•11 years ago
|
||
There will be a conversion patch here when I finish it.
Assignee | ||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f4f96dbf94f
Whiteboard: [leave open]
Comment 6•11 years ago
|
||
Backed out since bug 828817 was backed out: https://hg.mozilla.org/integration/mozilla-inbound/rev/fe51ccc53083
Assignee | ||
Comment 7•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e38024f2e18b
Assignee | ||
Comment 8•11 years ago
|
||
Attachment #701549 -
Flags: review?(bzbarsky)
Comment 9•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e38024f2e18b
Comment 10•11 years ago
|
||
Comment on attachment 701549 [details] [diff] [review] Convert sVGPathElement to WebIDL >+SVGPathElement::CreateSVGPathSegCurvetoCubicRel(float x, float y, float x1, float y1, float x2, float y2) You want a comment here mentioning the comment in CreateSVGPathSegCurvetoCubicAbs. >+SVGPathElement::CreateSVGPathSegCurvetoQuadraticAbs(float x, float y, float x1, float y1) And here. >+SVGPathElement::CreateSVGPathSegCurvetoQuadraticRel(float x, float y, float x1, float y1) And here. >+SVGPathElement::CreateSVGPathSegArcAbs(float x, float y, float r1, float r2, float angle, bool largeArcFlag, bool sweepFlag) And here. >+SVGPathElement::CreateSVGPathSegArcRel(float x, float y, float r1, float r2, float angle, bool largeArcFlag, bool sweepFlag) And here. >+SVGPathElement::CreateSVGPathSegCurvetoCubicSmoothAbs(float x, float y, float x2, float y2) And here. >+SVGPathElement::CreateSVGPathSegCurvetoCubicSmoothRel(float x, float y, float x2, float y2) And here. r=me with that
Attachment #701549 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 11•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d00c3bba9929
Whiteboard: [leave open]
Comment 12•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d00c3bba9929
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•