Closed Bug 827187 Opened 7 years ago Closed 7 years ago

Record default browser flag

Categories

(Firefox Health Report Graveyard :: Client: Desktop, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 20

People

(Reporter: gps, Assigned: gps)

References

Details

Attachments

(1 file)

We need a per-day flag on whether we are the default browser.

Patch is pretty simple.

Implementing a positive test will require a mochitest since the underlying nsIShellService doesn't appear to be available in xpcshell tests. Will file follow-up.
Attachment #698497 - Flags: review?(rnewman)
Comment on attachment 698497 [details] [diff] [review]
Record default browser flag, v1

Review of attachment 698497 [details] [diff] [review]:
-----------------------------------------------------------------

::: services/healthreport/providers.jsm
@@ +237,5 @@
> +      this._log.warn("Could not obtain shell service: " +
> +                     CommonUtils.exceptionStr(ex));
> +    }
> +
> +    let isDefault= -1;

Nit: space before =.

@@ +242,5 @@
> +
> +    if (shellService) {
> +      try {
> +        // This uses the same set of flags used by the pref pane.
> +        isDefault= shellService.isDefaultBrowser(false, true) ? 1 : 0;

Nit: space before =.
Attachment #698497 - Flags: review?(rnewman) → review+
https://hg.mozilla.org/services/services-central/rev/967ca515b012
Assignee: nobody → gps
Status: NEW → ASSIGNED
Whiteboard: [fixed in services]
Blocks: 827189
https://hg.mozilla.org/mozilla-central/rev/967ca515b012
https://hg.mozilla.org/mozilla-central/rev/894790d8efe4
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in services]
Target Milestone: --- → mozilla20
Component: Metrics and Firefox Health Report → Client: Desktop
Product: Mozilla Services → Firefox Health Report
Target Milestone: mozilla20 → Firefox 20
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in before you can comment on or make changes to this bug.