827191 - toggle calls not working

Status: RESOLVED INVALID

(Firefox OS Graveyard :: General, defect)

Description

[Anshul]

When there is one active call and another call on hold, clicking on any of the two calls supposed to toggle the calls as per "http://mxr.mozilla.org/gaia/source/apps/communications/dialer/js/oncall.js#52" but I don't see any RIL:HoldCall message received from content process.

Comment 1

[Hsin-Yi Tsai (she/her)[:hsinyi]]

(In reply to Anshul from comment #0)
> When there is one active call and another call on hold, clicking on any of
> the two calls supposed to toggle the calls as per
> "http://mxr.mozilla.org/gaia/source/apps/communications/dialer/js/oncall.
> js#52" but I don't see any RIL:HoldCall message received from content
> process.

I cannot reproduce this issue with 
  gecko: hg-mozilla-b2g18 117969:762e339e11c3 (Sun Jan 06 22:24:14 2013)
  gaia: master b506bdbd5bcdb042e3a8ca5d62856ae5d683c176 (Sat Jan 5 06:58:46 2013)

Everything worked well! I saw RIL:HoldCall messages in the log, and UI displayed as expected.

Anshul, would you please try the latest version? Thanks.

Comment 2

[Hsin-Yi Tsai (she/her)[:hsinyi]]

Attachment: log - call toggling works

Two calls are switched perfectly.

Comment 3

[Walter Chen[:ypwalter][:wachen]]

Hi,

I tried this with unagi pvt b2g18 build.
This is okay for me. (Worksforme)

If you can provide your failed version number and some other steps to reproduce, we can try to reopen this and see if it's reproduced.

Comment 4

[Anshul]

Walter/Hsin-Yi, I tested again and can not get toggle calls to work. Where on the screen should I press to toggle the calls. I have one held call and one active call and would like to switch between the two

gecko: 6ff5757db9d501dde1f8e9f0ef67eaaf2209b64e
gaia:  7c348f42b661f73f7223cdb12cef14946c66ab22

Comment 5

[Walter Chen[:ypwalter][:wachen]]

by providing commit string is not a valid way.
Please state the branch of gecko and gaia.

Like b2g18, beta, aurora, central, or blah blah blah gecko/gaia
and at least date of the build so that we can track easily.

If you can sync with us with pvt build, that would be better.
Also, please provide more detailed STR so that we know how to reproduce.

Comment 6

[Anshul]

Walter, we are on b2g18 branch. Steps to reproduce are:

1. Make an outgoing call from the device and have the other party accept the call.
2. Use a third phone to make an incoming call to the device
3. Click on the hold icon to hold the active call and accept the incoming call
4. Click on the held call to toggle the calls.

Comment 7

[Michael Vines [:m1] [:evilmachines]]

Reopening as we have not reached agreement that this is not an issue.

Comment 8

[Walter Chen[:ypwalter][:wachen]]

Still not working for me.
I will add qawanted and leave this to other qa

Comment 9

[Tony Chung [:tchung]]

Naoki and I just confirmed that Call waiting is not working.  here's the STRs.

Build 20130109070203

Repro:
1) set phone 2 to Settings > Call Settings > Call waiting = On
2) have phone 1 dial Phone 2
3) phone 1 and 2 are connected
4) have phone 3 to dial phone 2 
5) Verify phone 3 goes to voicemail

Expected: 
- Phone 3 should be ringing phone 2, and phone 2 should see a call waiting UI available to change calls

Actual:
- phone 2 never gets any 2nd incoming phone notification, and phone 3 goes straight to voicemail

Comment 10

[Hsin-Yi Tsai (she/her)[:hsinyi]]

(In reply to Tony Chung [:tchung] from comment #9)
> Naoki and I just confirmed that Call waiting is not working.  here's the
> STRs.
> 
> Build 20130109070203
> 
> Repro:
> 1) set phone 2 to Settings > Call Settings > Call waiting = On
> 2) have phone 1 dial Phone 2
> 3) phone 1 and 2 are connected
> 4) have phone 3 to dial phone 2 
> 5) Verify phone 3 goes to voicemail
> 
> Expected: 
> - Phone 3 should be ringing phone 2, and phone 2 should see a call waiting
> UI available to change calls
> 
> Actual:
> - phone 2 never gets any 2nd incoming phone notification, and phone 3 goes
> straight to voicemail

Hi Tony,

Thanks for verifying this. However, I don't think your steps are the same as what Anshul reported originally per my understanding. Anshul's issue is about *toggling* calls between an *active* and a *held* call, but what you were saying is  "no notification when a waiting call comes." So I am adding 'qawanted' again. If you do encounter the call waiting problem, please file another bug. 

B.t.w, the issue you reported in comment 9 looks like the case when call-waiting is disabled. Would be nice to check the call waiting status again. Thanks :)

Comment 11

[Hsin-Yi Tsai (she/her)[:hsinyi]]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #10)
> (In reply to Tony Chung [:tchung] from comment #9)
> > Naoki and I just confirmed that Call waiting is not working.  here's the
> > STRs.
> > 
> > Build 20130109070203
> > 
> > Repro:
> > 1) set phone 2 to Settings > Call Settings > Call waiting = On
> > 2) have phone 1 dial Phone 2
> > 3) phone 1 and 2 are connected
> > 4) have phone 3 to dial phone 2 
> > 5) Verify phone 3 goes to voicemail
> > 
> > Expected: 
> > - Phone 3 should be ringing phone 2, and phone 2 should see a call waiting
> > UI available to change calls
> > 
> > Actual:
> > - phone 2 never gets any 2nd incoming phone notification, and phone 3 goes
> > straight to voicemail
> 
> Hi Tony,
> 
> Thanks for verifying this. However, I don't think your steps are the same as
> what Anshul reported originally per my understanding. Anshul's issue is
> about *toggling* calls between an *active* and a *held* call, but what you
> were saying is  "no notification when a waiting call comes." So I am adding
> 'qawanted' again. If you do encounter the call waiting problem, please file
> another bug. 
> 
> B.t.w, the issue you reported in comment 9 looks like the case when
> call-waiting is disabled. Would be nice to check the call waiting status
> again. Thanks :)
Aha, sorry, you already said that you had set the value to 'on' ;-)

Anyway. I still can reproduce neither Anshul nor Tony's report ... ... 

It would be very helpful to attach the ril log. To enable it: 
-- edit gecko/dom/system/gonk/ril_const.js  set "this.DEBUG_ALL = true;"

Thanks again :)

Comment 12

[Anshul]

Hsin-Yi/Walter, I tried again on the tip and the toggle call is working fine for me now. I am closing this issue.

Comment 13

[Tony Chung [:tchung]]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #11)
> (In reply to Hsin-Yi Tsai [:hsinyi] from comment #10)
> > (In reply to Tony Chung [:tchung] from comment #9)
> > > Naoki and I just confirmed that Call waiting is not working.  here's the
> > > STRs.
> > > 
> > > Build 20130109070203
> > > 
> > > Repro:
> > > 1) set phone 2 to Settings > Call Settings > Call waiting = On
> > > 2) have phone 1 dial Phone 2
> > > 3) phone 1 and 2 are connected
> > > 4) have phone 3 to dial phone 2 
> > > 5) Verify phone 3 goes to voicemail
> > > 
> > > Expected: 
> > > - Phone 3 should be ringing phone 2, and phone 2 should see a call waiting
> > > UI available to change calls
> > > 
> > > Actual:
> > > - phone 2 never gets any 2nd incoming phone notification, and phone 3 goes
> > > straight to voicemail
> > 
> > Hi Tony,
> > 
> > Thanks for verifying this. However, I don't think your steps are the same as
> > what Anshul reported originally per my understanding. Anshul's issue is
> > about *toggling* calls between an *active* and a *held* call, but what you
> > were saying is  "no notification when a waiting call comes." So I am adding
> > 'qawanted' again. If you do encounter the call waiting problem, please file
> > another bug. 
> > 
> > B.t.w, the issue you reported in comment 9 looks like the case when
> > call-waiting is disabled. Would be nice to check the call waiting status
> > again. Thanks :)
> Aha, sorry, you already said that you had set the value to 'on' ;-)
> 
> Anyway. I still can reproduce neither Anshul nor Tony's report ... ... 
> 
> It would be very helpful to attach the ril log. To enable it: 
> -- edit gecko/dom/system/gonk/ril_const.js  set "this.DEBUG_ALL = true;"
> 
> Thanks again :)

Hsin-yi, i'll try to reproduce with the ril log. if i do, i'll file a new bug.

Anshul, thanks for retesting.  this bug will remain closed.