827197 - Remove some uses of nsIDOMSVGElement subclasses

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[David Zbarsky (:dzbarsky)]

Attachment: Patch

Comment 1

[Robert Longson [:longsonr]]

Comment on attachment 698517 [details] [diff] [review]
Patch

>+        if (rootElement->IsSVG() && rootElement->Tag() == nsGkAtoms::svg) {

    if (rootElement->IsSVG(nsGkAtoms::svg) {

>+                  nsIContent* child = childNodes->Item(i);
>+                  if (child->IsSVG() && child->Tag() == nsGkAtoms::title) {

                  if (child->IsSVG(nsGkAtoms::title)) {

I tell you what, let's assume I make the same comment everywhere in this patch it's possible to do this and you fix it everywhere you've done it.

>-    nsCOMPtr<nsIDOMSVGTSpanElement> tspan = do_QueryInterface(aContent);
>-    nsCOMPtr<nsIDOMSVGAltGlyphElement> altGlyph = do_QueryInterface(aContent);
>-    NS_ASSERTION(tspan || altGlyph, "Content is not an SVG tspan or altGlyph");
>+    NS_ASSERTION(aContent->IsSVG() && (aContent->Tag() == nsGkAtoms::altGlyph ||
>+                                       aContent->Tag() == nsGkAtoms::tspan),
>+                 "Content is not an SVG tspan or altGlyph");

Which is pretty much everything except this case as far as I can see.

r=me with above comment addressed everywhere it occurs.

Comment 2

[David Zbarsky (:dzbarsky)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fe40f8da7644

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/fe40f8da7644