827233 - [Contacts & Dialer Missed Call Log] Add feedback when calling from Contacts or Call Log and No SIM/No Network/Airplane mode

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect, P2)

Description

[Tony Chung [:tchung]]

In Contacts, tapping a listed phone number is no longer launching the dialer activity.  

no logcat activity either.

Repro:
1) install 20130106070203 daily unagi build
2) launch contacts, and have a phone number existing in a contact
3) tap the phone number under "Mobile"
4) Verify its not launching the dialer application activity

Expected:
- tapping the phone number launches dialer activity

Actual:
- tapping the phone number does nothing, stays in contacts app.

Comment 1

[alberto.pastor]

We are not using Activities anymore, but calling mozTelephony.dial instead. After debugging, it seems that we are successfully calling the dial method from gaia, but not receiving the telephony-new-call system message. Probably a platform bug.

Comment 2

[Vicamo Yang [:vicamo][:vyang]]

HsinYi, can you help this?

Comment 3

[alberto.pastor]

I think I see what's happening. I just realized that it happens only when it doesn't have network. So the problem is that we need to add feedback when no network / airplane mode and calling from contacts or call log.

Comment 4

[Tony Chung [:tchung]]

Confirmed, this only happens if no SIM card or no Carrier is detected (eg, Emergency only mode).

if works fine if your SIM card is registering a number.   i just learned this affects Contacts App and Dialer App: Missed Call Log

Re-nominating for triage, in that this fixing work involves a better error handling message if a user does not have a SIM card active.  The key fix here is just to send a friendly error message telling the user that this is disabled (airplane mode also?)  Will affect l10n, but i'm told that we can reuse the dialer error message that already landed.

Comment 5

[alberto.pastor]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7335

Pointer to Github pull-request

Comment 6

[alberto.pastor]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7335

Pointer to Github pull-request

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Just went through the review and test the cases on the phone (both dialer and calling from contacts) and it's looking good.

Great job!

Comment 8

[Axel Hecht [:Pike]]

Comment on attachment 698725 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7335

Grabbing the review request from stas here. Please don't change the callAirplaneModeMessage string. If that needs to be changed, file a new bug on that? The wording of it shouldn't be part of this bug.

Comment 9

[alberto.pastor]

Locales backed out and new bug created for tracking the dialogues wording -> https://bugzilla.mozilla.org/show_bug.cgi?id=827606

Comment 10

[Axel Hecht [:Pike]]

Alberto, it seems that you're using the same helper js in both contacts and dialer, but independent localizations of the strings in that helper? Is there no way to maintain those strings only in one place?

If not, there should at least be a comment that makes sure we get consistent translations.

Comment 11

[alberto.pastor]

I was not sure about performance implications creating a new shared locale, but after talking with Kaze it seems that is a good option, so I'll go for it. Thanks!

Comment 12

[alberto.pastor]

Done. Axel, could you please review again?
Thanks!

Comment 13

[Axel Hecht [:Pike]]

Comment on attachment 698725 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/7335

Looks good to me, thanks.

I'll make sure to post a note about the moved strings when I migrate the strings to gaia-l10n.

Comment 14

[alberto.pastor]

https://github.com/mozilla-b2g/gaia/commit/ef12adf10c91980fff0ecf6600d8114b63cd95ad

Comment 15

[Delphine Lebédel]

Verified fixed in 2013-01-31-07-02-01 pvt nightly b2g18 build