827237 - Wifi: ap list in settings is empty

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

This bug happens in current inbound and central branches, but not in b2g18 branch.

STR:
1. Open Settings App.
2. Choose Wifi

Expected: Available Wifi aps are listed in "Available networks".

Actual: "Available networks" stops in "Searching...".

Note: If we turn off Wifi in Setting, we are not able to turn on again before rebooting the phone.

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

qawanted to find regression range in where it broke.

Comment 2

[Eric Chou [:ericchou] [:echou]]

Bluetooth has the same problem. Turning on Bluetooth would disable the switch button and it would be unable to be switched again.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Gregor is on this. The regressor is a settings service change.

Comment 4

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Wouldn't hold release on it but bb+ to streamline landing.  This is severely affecting developers.

Comment 6

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 7

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 698640 [details] [diff] [review]
patch

Review of attachment 698640 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/settings/SettingsService.js
@@ +55,5 @@
>            let message = info.message;
>            if(typeof(value) == 'object')
>              debug("object name:" + name + ", val: " + JSON.stringify(value));
> +          let checkKeyRequest = store.get(name);
> +          

Nit: whitespace here and a few lines down.

@@ +56,5 @@
>            if(typeof(value) == 'object')
>              debug("object name:" + name + ", val: " + JSON.stringify(value));
> +          let checkKeyRequest = store.get(name);
> +          
> +          checkKeyRequest.onsuccess = function (event) {

Need an onerror handler too.

@@ +70,3 @@
>  
> +            req.onsuccess = function() {
> +              debug("set on success");

Nit: if (DEBUG) this

Comment 8

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 9

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d2c5708db6ef

Comment 10

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/mozilla-central/rev/206ab8775b40

Comment 11

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/f3e812fe7621

Comment 14

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d2c5708db6ef
https://hg.mozilla.org/mozilla-central/rev/c5fa0c2a3560