827253 - B2G Contact: Support exporting contacts to other device storage in ContactManager

Status: RESOLVED INVALID

(Core :: DOM: Device Interfaces, defect)

Description

[Edgar Chen [:edgar]]

Support exporting contacts to SIM card in ContactManager

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Hi, Gregor
I have sent a mail to dev-webapi to ask about the API for SIM contacts[1],

Do you have any comment/suggestion about this?

thanks


[1] https://groups.google.com/forum/?hl=en&fromgroups=#!topic/mozilla.dev.webapi/7bxfP7EwNT8

Comment 2

[Nivi]

Hi Yoshi/Gregor,

Do you guys know how is the export contacts UI going to look like? Are we planning to export all contacts if so will we overwrite everything on the SIM? Or do we plan to export one contact or in batches? What happens if we’re exporting more contacts than max number of contacts allowed by SIM? Do we have answers to questions like these? If so, could you share those with us?

Nivi.

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Hi, Nivi

(In reply to nsarkar from comment #2)
> Hi Yoshi/Gregor,
> 
> Do you guys know how is the export contacts UI going to look like?
You could see Bug 831633
But seems the UX hasn't started this yet.

> Are we
> planning to export all contacts if so will we overwrite everything on the
> SIM? Or do we plan to export one contact or in batches? What happens if
> we’re exporting more contacts than max number of contacts allowed by SIM? Do
> we have answers to questions like these? If so, could you share those with
> us?
> 
> Nivi.
Currently we're still discussing on mozilla-dev-api about the API
But seems no response yet.

For implementation, for simplicity, we now plan to export one contact at a time,
as you said, if in batches, we need to consider number of free records in ADN, and their record identifiers, error handling, etc.

We're still waiting if someone could comment on dev-web-api about the interfaces.

But you are welcome to comment or file some bugs.

[1] https://groups.google.com/d/msg/mozilla.dev.webapi/8rQolgohaaw/grWlhnj5aaYJ

Comment 4

[Edgar Chen [:edgar]]

Attachment: Part 1: IDL for exporting contact to SIM, v1

Add a new API to export contact into SIM card, addSimContact(). For simplicity, we export one contact at a time.

Comment 5

[Edgar Chen [:edgar]]

Attachment: Part 2: Modify ContactManager for exporting contact to SIM, v1

Hi Gregor, could you help to review or provide some feedback when you are available?

Thanks.

Comment 6

[Gregor Wagner [:gwagner]]

We should find a more generic way so we don't have to add a new function for every new back-end we want to support. Yoshi might have some ideas here.

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 709615 [details] [diff] [review]
Part 1: IDL for exporting contact to SIM, v1

Review of attachment 709615 [details] [diff] [review]:
-----------------------------------------------------------------

Cancel r? since Gregor would like to make this API more generic, i.e. suit for multi-sim or sdcard, or other address phone on device, ... etc.

Comment 8

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 709616 [details] [diff] [review]
Part 2: Modify ContactManager for exporting contact to SIM, v1

Review of attachment 709616 [details] [diff] [review]:
-----------------------------------------------------------------

Cancelling r? with same reason above.

Comment 9

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Hi, Gregor
In this bug we're trying to do 'exporting contacts to external device storage, said SIM, sdcard ..etc"

How about 'update the contact in the external device storage" ?

Currently in ContactManager.save, it will look for 'id' property for the contact to decide to create or update.
Should we do the same in this 'export' interface, with using another property might call 'contactId' ?
Or should we create another API for update?

thanks

Comment 10

[Kai-Chih Hu [:khu]]

Do we have any idea about the remaining efforts? Thanks.

Comment 11

[Edgar Chen [:edgar]]

According to the discussion in bug 838092, close this bug as INVALID and file bug 847820 to follow up.