827288 - Pressing home to exit activity picker gets device into busted state

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect, P2)

Description

[:Margaret Leibovic]

STR:
1) Open gallery app
2) Select photo
3) Tap share icon
4) Tap home button

Expected results:
Return to home screen

Actual results:
Gray background covers screen

Comment 1

[Dylan Oliver [:doliver]]

Reproduced and had to reboot to get things working again.

Comment 2

[:Margaret Leibovic]

I started looking into this, and I found that the transitionend listener in list_menu.js is never firing. It doesn't look like this logic has changed in a while, do we know if this was ever working properly or if this is a recent regression?

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

I found that if the listener is registered on the document object, the transitionend event is received. Maybe a platform bug?

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

The patch just add a

setTimeout(function() {
  container.classList.add('slidedown');
});

Comment 5

[:Margaret Leibovic]

Comment on attachment 698978 [details] [diff] [review]
Patch

Ew, setTimeout. Do you know why this works? I assume it's related to weird stuff going on with the 'home' event. I think you should add a comment about why we're doing this.

Also, you shouldn't make so many unnecessary style changes in your patch :P

r+, but I would prefer if you land this with a comment, and consider minimizing the extra changes.

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Margaret Leibovic [:margaret] from comment #5)
> Comment on attachment 698978 [details] [diff] [review]
> Patch
> 
> Ew, setTimeout. Do you know why this works? I assume it's related to weird
> stuff going on with the 'home' event. I think you should add a comment about
> why we're doing this.
> 
> Also, you shouldn't make so many unnecessary style changes in your patch :P
> 
> r+, but I would prefer if you land this with a comment, and consider
> minimizing the extra changes.

https://github.com/mozilla-b2g/gaia/commit/39caebce2231846dd2fa4b70851322707bbb9843

Argh! I merged too quickly with the extra changes. Sorry about that (I don't think those are harmfuls but yeah they are not really useful for the purpose of this patch...), I don't think it worth a backout though.

I will do better next time!

Comment 7

[u279076]

Not able to reproduce this bug using B2G 1.0.0-prerelease 18.0 20130110070201 build. Marking verified fixed.